MarkShark

So much for hopeful thinking on my part! First couple of projects compiled without issues, then I tried one with the TOmniThreadLibrary and boom. I use TOmniValue.FromRecord() with a record with strings in it, which I believe is the issue here. Anyone know a workaround for that? I have to admit that its worked so well up til now that I haven't looked back at that code in while.

Following this with great interest, but the main question is "Does this mean that we should wait on installing patch 2?" I like the idea of debugger stability fixes, etc., but if this adversely affects some of my favorite libraries (e.g. Spring4d!) then it's a show stopper. Any thoughts?

Geoffrey, thank you for this. I had no problems getting it working (with G Suite from a Delphi 10.4 app.) Nicely done!

Edwin, that's very helpful, Thank you!

Good tip! I have a number of old libraries like this that I keep using with newer Delphi versions. My solutions is to do something like: {$if CompilerVersion >= 23} {$DEFINE XE2PLUS} {$ifend} That way I don't have to keep changing it with new releases.

Thanks to everyone who responded to this! I'm new to git (and to contributing to open source projects) so I installed a bunch of stuff, cloned the SynEdit2 repository, made a branch (I think that's the correct thing), went to add the wordwrap fix I mentioned above... and found that pyscripter had already fixed it last December and I had totally missed it. Nice! I'm going to attempt a pull request on a very minor fix I have to try to get my feet wet on the process.

I always do Stopwatch := TStopwatch.StartNew; On a side note I wonder if the new managed records thing could make your original one work (which I would prefer.)

That's awesome. Thank you Uwe!

Watching this with great interest! This level of knowledge is beyond me, but as a consumer of the Delphi library code it would be fantastic to hear that is has been fixed. What's the best way to "suggest" that Embarcadero incorporate any found fixes? Contacting Marco? Voting for a QC report? Something else? A big thanks to all contributors on this, it really is fascinating.

Uwe - thanks for the source for that! I'll be checking that out.

I use the MMX Code Explorer for that. The feature is a bit hidden and listed under "Group and Sort Uses". I think it only works on the current uses statement (e.g. you need to put the caret on the uses clause and hit the hotkey for it. It does work well as I've used it quite a bit when working with my older units.

HFileRes should be a THandle instead of HFILE (which is a LongWord). In 64bit CreateFile returns a 64bit value and you are assigning it to a 32bit one. On a side note I just checked Delphi RIO and still no compiler hint for this type of thing... Seems like that would be useful. -Mark