Jump to content

MarkShark

Members
  • Content Count

    86
  • Joined

  • Last visited

Posts posted by MarkShark


  1. Thanks to everyone who responded to this!  I'm new to git (and to contributing to open source projects) so I installed a bunch of stuff, cloned the SynEdit2 repository, made a branch (I think that's the correct thing), went to add the wordwrap fix I mentioned above... and found that pyscripter had already fixed it last December and I had totally missed it.  Nice!  I'm going to attempt a pull request on a very minor fix I have to try to get my feet wet on the process.

     

    • Like 3

  2. Hey all.  I use SynEdit in a few projects and I was wondering if anyone has insight on which of the various version is the preferred one to use.  I'm on 10.4 and don't need backwards compatibility btw.

     

    The one that is on "GetIt" appears to be an older version (1.5.)

     

    The one listed as SynEdit2 on github by pyscripter appears to be active, includes some nice changes (ole drag and drop for example) lots of fixes and cleanup (some related to removing support for older Delphi versions.)

     

    The one listed as SynEdit/SynEdit on github which seems to be more actively developed then the other two.

     

    I've worked with the second two and, as always, it seems when working with third party components I have to make a few changes to the source (adding some missing properties, fixing the extra space on word wrap lines (thanks to a stack overflow answer) and a few other minor issues) which have to be merged into each new update, so picking the "correct" one will obviously help.   On a side note I have a feeling that the correct answer might be that there is no correct answer...

     

    Just looking for any feedback or thoughts.   And this post wouldn't be complete without thanking and acknowledging all the great work people have done on these projects!

     

    -Mark

     

    • Like 2

  3. Watching this with great interest!  This level of knowledge is beyond me, but as a consumer of the Delphi library code it would be fantastic to hear that is has been fixed.  What's the best way to "suggest" that Embarcadero incorporate any found fixes?  Contacting Marco?  Voting for a QC report?  Something else?  A big thanks to all contributors on this, it really is fascinating.

    • Like 1

  4. I use the MMX Code Explorer for that.  The feature is a bit hidden and listed under "Group and Sort Uses".    I think it only works on the current uses statement (e.g. you need to put the caret on the uses clause and hit the hotkey for it.  It does work well as I've used it quite a bit when working with my older units.


  5. HFileRes should be a THandle instead of HFILE (which is a LongWord).  In 64bit CreateFile returns a 64bit value and you are assigning it to a 32bit one.  On a side note I just checked Delphi RIO and still no compiler hint for this type of thing...  Seems like that would be useful.

     

    -Mark

×