Kyle_Katarn31

Hello, I'm using TsslHttpCli to connect from my app to my servers. What's the method to be used to check on client side if TLS 1.1, 1.2 or 1.3 is being used ? Thanks !

Thanks, i'll check this !

OverbyteIcsFileCopy.pas Line 1583 and 1584 : IgnorePathList.Delimiter, '"' + IgnorePathList.Delimiter + '"', [rfReplaceAll]) + '"'; { V8.63 for D7 } IgnorePathList.DelimitedText := '"' + StringReplace(AnsiLowerCase(FIgnorePaths), does not compile (obviously wrong) with Delphi 7

My mistake, already reported here :

Works fine, thanks !

http://wiki.overbyte.eu/wiki/index.php/ICS_Download seems down on my end.... do you confirm ?

Some observations : { V8.65 look for absolute URL sent by proxy } I := Pos('://', FPath); if (I = 4) or (I = 5) then begin FPath := Copy(FPath, I + 3, 99999); // strip http:// I := Pos('/', FPath); // start of path if (I > 1) then FPath := Copy(FPath, I, 999999); // strip host end; Magic numbers 99999 and 999999 to be replaced with actual expected FPath extract length ? else begin { see if we have access to file, but don't read it yet } TempStream := TFileStream.Create(FDocument, fmOpenRead + fmShareDenyWrite); TempStream.Destroy; OK := TRUE; end; Destroy is called even if .Create fails and the global code section is a nonsense as always returns OK = TRUE whatever the access rights TempoStream.Free shall be called rather than TempoStream.Destroy

Thanks "This won't matter for much longer since the next major release of ICS will cease support for compilers more than a few years old" You mean that you are about to drop Delphi 7 support ? What a bad news !

Hello When running a software of mine in ReactOS i'm getting rare Delphi exception "Delphi Exception at address: 0049F658". Using IDR I identified that this corresponds to TCustomSmtpClient.Destroy; Looking at the code i'm surprised to see that the "safe destroy" pattern is used for FHdrLines and FAuthTypesSupported but NOT for FMailMessage and FRcptName, while all 4 of them are TStrings created in the constructor. if Assigned(FHdrLines) then begin FHdrLines.Destroy; FHdrLines := nil; end; if Assigned(FAuthTypesSupported) then begin FAuthTypesSupported.Destroy; FAuthTypesSupported := nil; end; FMailMessage.Destroy; FRcptName.Destroy; I would have simply expected FHdrLines.Free; FAuthTypesSupported.Free; FMailMessage.Free; FRcptName.Free; (or FreeAndNil(variable) ) Is it intentionnal ? same in TFingerCli.Destroy; TDnsQuery.Destroy; TCustomPop3Cli.Destroy; Similar issue with TFormDataAnalyser.PartSaveDataToFile, TFormDataItem.SaveToFile, TIcsFtpMulti.IntDownOne, OverbyteIcsFtpMultiW, OverbyteIcsFtpSrv, OverbyteIcsFtpSrvW where .Destroy is called while .Free would be expected Same for OverbyteIcsFtpCli.pas (3 occurences of FModeZStream.Destroy; instead of FModeZStream.Free;) ... global check to be done.

No, never seen this but very often this kind of exception are "hidden" by Windows....

Not possible. Random exception while running for a long time in ReactOs (far from my IDE)

MaxInt or expected length to be copied (Length()-xxx)

Exception : (dll/win32/kernel32/client/except.c:735) Delphi Exception at address: 0049F658 (dll/win32/kernel32/client/except.c:736) Exception-Object: 009CB4C4 (dll/win32/kernel32/client/except.c:737) Exception text: 955cb0 MAP file : 049F09C:{OverbyteIcsSmtpProt}constructor TCustomSmtpClient.Create(AOwner:TComponent); 049F2F8:{OverbyteIcsSmtpProt}destructor TCustomSmtpClient.Destroy; 049F398:{OverbyteIcsSmtpProt}procedure sub_0049F398(?:?; ?:?); 049F400:{OverbyteIcsSmtpProt}procedure sub_0049F400; 049F410:{OverbyteIcsSmtpProt}procedure sub_0049F410; 049F44C:{OverbyteIcsSmtpProt}procedure sub_0049F44C; 049F488:{OverbyteIcsSmtpProt}procedure sub_0049F488(?:?); 049F51C:{OverbyteIcsSmtpProt}procedure sub_0049F51C(?:?); 049F5A8:{OverbyteIcsSmtpProt}procedure sub_0049F5A8(?:?); 049F5D0:{OverbyteIcsSmtpProt}function sub_0049F5D0(?:?; ?:?):?; 049F634:{OverbyteIcsSmtpProt}procedure sub_0049F634(?:TCustomSmtpClient); 049F680:{OverbyteIcsSmtpProt}procedure sub_0049F680; 049F6A0:{OverbyteIcsSmtpProt}procedure sub_0049F6A0(?:?); 049F6C0:{OverbyteIcsSmtpProt}procedure sub_0049F6C0(?:?); 049F6E0:{OverbyteIcsSmtpProt}procedure sub_0049F6E0(?:?); 049F780:{OverbyteIcsSmtpProt}procedure sub_0049F780(?:TCustomSmtpClient; ?:?); 049F7A0:{OverbyteIcsSmtpProt}procedure sub_0049F7A0(?:?); 049F7FC:{OverbyteIcsSmtpProt}procedure sub_0049F7FC(?:?); 049FA30:{OverbyteIcsSmtpProt}procedure sub_0049FA30(?:?; ?:?); 049FE08:{OverbyteIcsSmtpProt}procedure sub_0049FE08(?:?); 049FED8:{OverbyteIcsSmtpProt}procedure sub_0049FED8(?:TCustomSmtpClient; ?:?; ?:AnsiString; ?:?; ?:?; ?:?; ?:?);

Then argument to be filled with actual needed length

Any clue or comment?

Just a comment. No problem. My problem is on the assert in the other thread

Ok. So at least the Copy enhancement to be considered ?

Yes, right. Anyway : TempoStream.Free shall be called rather than TempoStream.Destroy

That's exactly my point.

Code comes from ICS TCustomSmtpClient.Destroy; Compiled with D7 Not fully reproductible but there might be something rotten here. anyway I agree that simply calling .free or FreeAndNil would be a wiser option here

When using HTTP proxy with TSSLHttpCli : If no Auth is required (no credentials), is it OK to use httpAuthBasic with "empty" login/pass ? Or should I revert to httpAuthNone in this case ?

Ok, thanks !

You mean pcap ? Or logging of specific events / traffic at application level ?

In OverbyteICSHttpProt.pas:3479 { pending, check https for SSL prpoxy, maybe socks for socks proxy } proxy, not prpoxy

OK... maybe worth being removed...