luebbe

See my previous post:

- Docking "pure" IDE windows, save/restore desktop works

- Docking third party windows, save/restore desktop fails

Not properly saving/restoring window positions on a secondary monitor is clearly to blame on the IDE. This has never worked correctly (for me) since I got a secondary monitor (first tried with 10.1/10.2).

When I dock more IDE child windows on the secondary monitor, everything is fine. Save and restore works (apart from the coordinates).

Something goes wrong when the coordinates of third party add-ons are saved (tried with TestInsight, GExperts Grep).

- If the windows are undocked, the coordinates aren't saved at all. The windows disappear as soon as the desktop is restored.

- If the windows are docked, an A/V occurs when the desktop is restored.

I guess the A/V when restoring a docked child window is to blame on the combination IDE (TestInsight|Grep), because one of them tries to apply VCL Styles to the (TestInsight|Grep) window and fails.

The IDE throws an A/V reliably in the following case:

- Place an IDE window (messages) on a secondary monitor

- Dock another window (TestInsight) onto the messages window

- Save this Desktop

- Restore this Desktop

This has never worked well (the coordinates of the window(s) on the secondary monitor were never restored correctly), but at least it didn't crash until 10.4.0.

That's weird. The very moment when I save my standard layout, two, previously invisible windows pop up at the center of the screen: "GExperts grep results" (ok, but wasn't active) and "Keyboard Macro Library" (never used that).

But when I start with "New VCL project", which custom layout would that be?
I guess, I'll delete "Appdata\Roaming\ ... \Default Layout.dst" and start from scratch

It looks like it has to do something with the desktop layout. When I load the Card Panel Demo from the start page I get an AV in rtl270.bpl. which shows TDesktopform.SaveDockClients in line 6-7.

Sometimes I don't get an A/V at all. The IDE just closes after showing the busy cursor.

"File->New VCL application" is enough to crash the IDE without error message.

It also crashes (with error message) when I switch from "start layout" to "standard layout" without trying to load anything. Then the crash is in Vcl.Themes.TStyleHook.WndProc

probably it's either GExperts or TestInsight which cause the problems. When I close their windows and save this as "Standard Layout", the A/Vs are gone and I "File-New VCL" seems to work. I'll investigate further.

Oh boy,

Installed 10.4.1, TMS Components, GExperts and TestInsight, dragged a .groupproj onto the IDE to install more components and the IDE crashes completely. So much for a "quality" update 😞

Yes, I saw your PR in SVGIconImageList and I think I came across IconFontsImageList a while ago, but didn't try it, because I wanted to use SVG. I'll keep an eye on both projects.

So many gems on GitHub that I learned about today and so many more to discover. Thank you!

We have the full VCL UI Pack and I'm planning to port our applications to the SVG image list until the end of the year. We are already using SVG Icons, but we currently render them to bitmaps with cairo and use standard image lists.

13 minutes ago, David Heffernan said:

Probably it is mature now.

Yes and no. There was almost no activity on FixInsight from the end of 2017 until the end of 2019 and there were several open issues. By the end of 2019 bugs were fixed again and new features were added.

Yes, FixInsight is great. Although it doesn't get as many updates anymore as it did in the first year. Basically only one per Delphi version. But 2020 seems to be a better year for FixInsight customers 😉

The Japanese parts that I can decipher are correct 😄

Isn't it common practice to store pointers to objects in the tag property? At least that's what I've learned by looking at some legacy code 😉

/sarcasm off

Do you know the name of the constant by chance? Then I could grep the delphi sources.

On 10.3.1 the GExperts Grep window causes crashes, when it is docked. The problem seems to be caused by VCL Styles. When the grep window is floating free, nothing bad happens. I haven't seen any correlation with FixInsight, but that doesn't mean anything.

If you're sure that FixInsight is the culprit, please post it in the TMS Forums. Roman has become more active lately...

Hi Folks,

currently I'm trying to add a default exception handler to our logging framework. I wanted to add a test case to DUnitX using a mock logchannel. The problem I'm facing is that DUnitX already catches the exception so that it never gets delivered to the logger.

When I wrap the exception into Assert.WillRaise() DUnitX is happy, but the mock verification fails, because g_Logger.DoOnException never gets called and thus the message never gets delivered to the channel. If I don't wrap it, DUnitX catches the exception and the test fails.

Is this possible at all? Am I heading down a totally wrong path?

procedure TestLogChannel.TestReceivesAnyException;
var
  MC: TMock<ILogChannel>;
begin
  Application.OnException := g_Logger.DoOnException;

  // Set up the mock log channel
  MC := TMock<ILogChannel>.Create;

  try
    g_Logger.RegisterChannel(MC);

    MC.Setup.Expect.Once('Deliver');       // Check whether a message has been delivered to this channel

//    Raise EDivByZero.Create('Thou shalt not do this');

    Assert.WillRaise(
      procedure
      begin
        Raise EDivByZero.Create('Thou shalt not do this');
      end, EDivByZero);

    Assert.WillNotRaise(
      procedure
      begin
        MC.Verify;
      end, EMockVerificationException);

    g_Logger.UnregisterChannel(MC);

  finally
    MC.Free;
  end;
end;

A github search revealed these:

- https://github.com/coolsoftware/VHashedStringList

- https://github.com/bodo-hugo-barwich/hash-lists

I didn't take a closer look. Just dumping the links here.

You might also consider the french 77 or 99, which are expressed as:

• 77 -> soixante-dixsept (60 + 17)
• 99 -> quatrevingt-dixneuf (4 * 20 + 19)

as a nice complicated example

From a German point of view, Swiss and Dutch sound like someone has a bad cold, but danish isn't far behind. GD&R.

You have to add (System.)Actions to the uses clause of Gx_IdeUtils.pas for "newer" versions of Delphi to compile.

Newer means, that at least 10.2 and 10.3 need the Actions unit. I can't check with older Delphi versions.

I compiled with 10.3 and copied the resulting dll to the installation directory. No more crashes upon startup and the experts that I used worked. Thanks for the fix.

During start GExperts now complains that some default icons are missing from the icons folder.
I copied GXIcons.rc and GXIcons.res from the sources into a Icons folder underneath the installation folder, but still get the error message shown in the screenshot. GotoExpert.bmp is indeed missing from the images folder in the sources.

Done. Enjoy your vacation 🙂

When I install 1.3.14 into Delphi 10.3 Update 1, I receive the following error message when the IDE starts:

---------------------------
bds.exe - Einsprungpunkt nicht gefunden
---------------------------
Der Prozedureinsprungpunkt "@System@Classes@TFieldsCache@$bcctr$qqrv" wurde in der DLL "C:\Program Files (x86)\GExperts for RAD Studio 10.3\GExpertsRS103.dll" nicht gefunden.
---------------------------
OK   
---------------------------

Sometimes the IDE continues and works, sometimes it becomes unresponsive and I have to kill it with task manager.

Uninstalled 1.3.14, reinstalled 1.3.13 and everything is fine.

Other installed plugins are:

- FixInsight 1.1.1.6

- Compiler Speed Pack 6.4.1

- IDE Fix Pack 6.4.1

The same happens with 1.3.14 and Delphi 10.2. Update 3 Didn't copy the error message though.

Plugins there:

- FixInsight 1.1.1.5

- Compiler Speed Pack 6.3.1

- IDE Fix Pack 6.3.1

15 hours ago, Darian Miller said:

 

A very simple comparison is:  FixInsight offers some analysis for the code that you have open.  SonarCube tracks entire projects over time.  SonarCube also has quality gates for branches which you can allow check-ins or not based on code quality metrics.  Many other features and plugins are available.

 

I'd compare FixInsight to Pascal Expert (https://www.peganza.com/products_pex.html)    Pascal Analyzer is Pascal Expert's much older brother with a ton more reporting options:  https://www.peganza.com/products.html#PAL   

If you use FixInsight on a build server (e.g. Jenkins) and import the FixInsight log files into the Jenkins warnings-ng plugin, you get a SonarQube like experience, plus the quick tests in the IDE. I'm happy with this combination.

23 hours ago, David Hoyle said:

Re-FixInsight - after chasing up Roman, I got an email acknowledging the issue (crashing 10.3 on exit) and then a few days later a patch to test (I said I was not going to renew until the issue was fixed). It has fixed the crashes but it does not seem he has issues out a new version. I would suggest chasing him up through the support feature.

The latest official version of FixInsight is 2019.01 from January this year. Unfortunately neither Roman nor TMS updated the changelog and I don't know by heart what has changed since the previous 2017.11 release. The 2019.01 is ok, but it has concurrency issues. You will get crashes if several instances run in parallel (e.g. on a build server). Roman says he has fixed this issue and there is an Update 1 available from his site: http://sourceoddity.com/download/FixInsight_2019.01upd1_setup.exe. This version introduces some unexpected warnings, which is why we don't use it in production.