Jump to content

Remy Lebeau

Members
  • Content Count

    2322
  • Joined

  • Last visited

  • Days Won

    94

Everything posted by Remy Lebeau

  1. Remy Lebeau

    Delphi says "x is not a valid integer value"

    In that case, you could just get rid of the offending StrToInt() altogether: procedure TFormSimpleVariable.ButtonShowValueClick(Sender: TObject); begin //x := StrToInt('x'); LabelResult.Caption := 'The value of x is ' + IntToStr(x); end; But that doesn't jive with what @357mag is asking for in the first place.
  2. Remy Lebeau

    I'm missing some nuance..

    Wow, that is just screaming for the SessionName to be moved into a common base class, or into a common interface that all of the components implement. If the TEDB... and Tnlh... components are from different libraries, I would simply derive my own classes from them, and define my own interface, eg: type IHaveASessionName = interface ['{6ea2f6fe-6b6f-4ea6-a893-12717e562329}'] function GetTheSessionName: string; procedure SetTheSessionName(const Value: string); property TheSessionName read GetTheSessionName write SetTheSessionName; end; ... type TMyEDBSession = class(TEDBSession, IHaveASessionName) function GetTheSessionName; procedure SetTheSessionName(const Value: string); end; function TMyEDBSession.GetTheSessionName; begin Result := SessionName; end; procedure TMyEDBSession.SetTheSessionName(const Value: string); begin SessionName := Value; end; // And repeat for TEDBDatabase, TnlhTable, TnlhQuery, TnlhScript, etc... ... for var i := 0 to ComponentCount - 1 do begin var Intf: IHaveASessionName; if Supports(Components[i], IHaveASessionName, Intf) then Intf.TheSessionName := sSessionName; end; If the components are on DFMs at design-time, you can alternatively use interposer classes in the DFM units, eg: type TEDBSession = class(edbcomps.TEDBSession, IHaveASessionName) function GetTheSessionName; procedure SetTheSessionName(const Value: string); end; // etc...
  3. That would not cause error 10093 (WSANOTINITIALISED). That error can only happen if a WinSock function is called either before the 1st call to WSAStartup() or after the last call to WSACleanup(). If bind() or listen() failed, they should be raising their own exception, which would terminate the daemon thread before it reaches the marked line of code, since it is not catching them.
  4. The WinSock library is reference-counted internally. WSAStartup() increments the refcount, and WSACleanup() decrements it. The library internals are initialized only on the 1st call to WSAStartup(), and cleaned up only on the last call to WSACleanup(). So, every successful call to WSAStartup() must be balanced with a call to WSACleanup(). The code you have shown looks fine (well, mostly ... your error handling needs work), which means that what you have described can occur only if SOME OTHER THREAD is making an unbalanced call to WSACleanup(), thus decrementing the refcount too much and unloading the library even though you are still using it. That is not the fault of the code you have shown, the problem is elsewhere in your project. What else is your project doing that uses WinSock outside of this TTCPHttpDaemon class? What do you mean? Something had to have changed, behavior like this doesn't just change for no reason. Unless, this bug was likely always present in your project to begin with, and you just never happened to hit on it until now. Doubtful.
  5. Remy Lebeau

    TValueListEditor how to catch exception when key exist?

    Like Peter said, try the OnSetEditText or OnValidate event. OnSetEditText is called when a new grid cell value is being saved. It is called before the cell is updated, and before the new value is validated. OnValidate is called if the InplaceEditor is active and modified when 1) before a new cell is selected, 2) when the ValueListEditor is losing input focus, 3) when the mouse is being pressed down on the ValueListEditor. Either way, you can raise an exception if the user input is not acceptable to you. For instance, you can raise a custom exception that a TApplication.OnException handler can look for, or you can call SysUtils.Abort() to raise an EAbort exception, which the VCL will catch and discard. You could handle the ValueListEditor's default keyUnique exception in the TApplication.OnException event. However, TValueListEditor does not use a specialized descendant class for that particular exception, it just uses the base SysUtils.Exception class directly. So, to differentiate that exception from others, you would have to look at its Message text, which is the localizable resource string "SKeyConflict" from the Vcl.Consts unit: SKeyConflict = 'A key with the name of "%s" already exists'; The exception will not terminate the program. It is being raised in a UI handler in the context of the main message loop, which will catch any uncaught exception, and either pass it to the TApplication.OnException event if assigned or just display it to the user. Either way, the exception is then discarded.
  6. Remy Lebeau

    TValueListEditor how to catch exception when key exist?

    TValueListEditor has a KeyIsValid() method, which has a RaiseError property. This is the same method that TValueListEditor calls internally, with RaiseError=True, but you can also call it yourself, with RaiseError=False, eg: procedure TForm1.Button1Click(Sender: TObject); var if TValueListStrings(ValueListEditor1.Strings).KeyIsValid('key1', False) then ValueListEditor1.InsertRow('key1', 'hello', true); end;
  7. Remy Lebeau

    Capture Ctrl-Click on a TButton?

    Alternatively, the OnMouse(Down|Up) events have a Shift parameter which defines several flags, including ssCtrl, which is present when the Ctrl key is down when the event is triggered.
  8. Remy Lebeau

    C to Pascal

    In small pieces, sure. Not whole projects. That is not what this site is for. Then I suggest you ask on one of the many freelancing sites available, such as freelancer.com or similar.
  9. Remy Lebeau

    How do I convert from string to char?

    Then you are going to have to show the actual error message, and the code it refers to. Every code I've shown here is correct and should be working fine. None of my examples have unused values. On the other hand, some of your examples do.
  10. Remy Lebeau

    Delphi says "x is not a valid integer value"

    Do note that setting TEdit.NumbersOnly=true merely tells the TEdit to accept only digit characters and no others (so, no negatives, no decimals, etc) , but it will not validate that the text as a whole will convert to a valid integer. So you still have to handle that conversion yourself, if you don't use a UI control that does it for you.
  11. Remy Lebeau

    Delphi says "x is not a valid integer value"

    On the other hand, the StrToxxxDef() functions don't let you differentiate whether valid vs invalid input was entered unless you use a sentinel value that can't appear in any valid input. The TryStrToxxx() functions let you differentiate very easily. Besides, what is the point of converting a string to an integer/floating type if you are not going to use the converted value anyway? var v: integer; begin // don't ignore the return value! // TryStrToInt('...', v); if TryStrToInt('...', v) then begin // use v as needed ... end else begin // error converting ... end; // don't ignore the return value! // StrToIntDef('...', 0); v := StrToIntDef('...', 0); if v <> 0 then begin // use v as needed ... end else begin // was the input actually '0', or did an error occur ??? end; end;
  12. Remy Lebeau

    Delphi says "x is not a valid integer value"

    And alternatively, the TryStrToxxx() functions.
  13. Remy Lebeau

    Using TIdHTTP in a thread

    I'm guessing that code is simply old and can now be removed.
  14. Remy Lebeau

    Delphi says "x is not a valid integer value"

    Do you understand what StrToInt() actually does? What do you think StrToInt('x') should do, and why do you think it should NOT throw an error (hint: it SHOULD)? The string 'x' is not representative of a valid integer value, so of course it can't be converted into an actual integer. You said the user is entering a value in an Edit box, but this code is not accessing that Edit box at all. You need something more like this instead: procedure TFormSimpleVariable.ButtonShowValueClick(Sender: TObject); var x: Integer; begin x := StrToInt(EditValue.Text); LabelResult.Caption := 'The value of x is ' + IntToStr(x); end; Alternatively, for numeric input, consider using a more appropriate UI control, like TSpinEdit or TNumberBox, which provide the input as actual integers rather than as strings.
  15. Remy Lebeau

    [Delphi] Indy, upload e download

    Your InviaRiceviFile() function is using the wrong Add method of TIdMultipartFormDataStream. You should be using either AddFile() or the TStream overload of AddFormField(). You are using the String overload of AddFormField() instead, which is meant for text fields, not binary data fields. So, you are setting the content of the 'file' field to be just the file path itself, rather than the content of the file that is located at the path. On a side note, don't use the TIdHTTP.Request.CustomHeaders property to specify a 'Content-Type' header, use the TIdHTTP.Request.ContentType property instead. Note that the TStrings overload of the TIdHTTP.Post() method already sets the ContentType to 'application/x-www-form-urlencoded' for you. Also, when using the TIdHTTP.Request.CustomHeaders property to send your own 'Authorization' header, the TIdHTTP.Request.BasicAuthentication property should be set to False, not to True. With that said, try this: function Login: string; const tokenUri = <https del portale che riceve credenziali e genera il token>; tokenToAskForAToken = <token string>; var Params: TStringList; Token: string; begin Result := ''; idhttp2.Request.BasicAuthentication := False; IdHttp1.Request.CustomHeaders.AddValue('Authorization', 'Basic ' + tokenToAskForAToken); IdHttp1.Request.ContentType := 'application/x-www-form-urlencoded'; try Params := TStringList.Create; try Params.Add('grant_type=client_credentials'); Token := IdHTTP1.Post(tokenUri, Params); Memo1.Lines.Add(Token); Result := 'bearer ' + Token; finally Params.Free; end; except on E: Exception do Memo2.Lines.Add(E.Classname + ': ' + E.Message); end; end; procedure InviaRiceviFile; const functionUri = <https del portale che riceve ed invia i file>; bdapFilePath = 'c:\temp\BDAP_P_2022.zip'; //file di input bdapZipFilePath = 'c:\temp\XBRL_BDAP_P_2022.txt'; //file di output var Params: TIdMultiPartFormDataStream; Response: TMemoryStream; begin idhttp2.Request.BasicAuthentication := False; IdHttp2.Request.CustomHeaders.Values['Authorization'] := Login; try Params := TIdMultiPartFormDataStream.Create; try Response := TMemoryStream.Create; try Params.AddFile('file', bdapFilePath, 'application/octet-stream'); IdHttp2.Post(functionUri, Params, Response); Response.SaveToFile(bdapZipFilePath); finally Response.Free; end; finally Params.Free; end; except on E: Exception do Memo2.Lines.Add(E.Classname + ': ' + E.Message); end; end;
  16. Remy Lebeau

    TIdIpMcastClient - Group join on second interface issue

    That post's code is a mix of Indy and manual coding. In any case, that post is saying that a multicast receiving socket needs to be bound to 0.0.0.0 or ::0 and then join each desired interface to the multicast group. Searching around, I see many other posts with similar advice. Although TIdIPMCastClient can bind its listening sockets to 0.0.0.0/::0 (just set Binding.IP = ''), it then joins their bound IP to the group, so it would be joining 0.0.0.0/::0 to the group, which is clearly not going to work. I may have to add a new event to TIdIPMCastClient that is called after binding to let users decide which interfaces to join, and then update TIdSocketHandle.AddMulticastMembership() to let a caller specify the interface to join (TIdStack.AddMulticastMembership() already has an ALocalIP parameter for that purpose, which TIdSocketHandle sets it its currently bound IP). According to this, Linux can't receive multicast packets if the listening socket is not bound to 0.0.0.0/::0. On the other hand, I've seen several posts, such as this one, which say a receiving socket should be bound to the multicast group IP instead of a local interface, and then join the desired interfaces to the group. Must be a Linux/Posix thing, because that advice is in direct conflict with Microsoft's documentation for receiving multicast on Windows: So, I'm not sure what to think at this point. It seems that everyone agrees that binding a receiver socket to 0.0.0.0/::0 and then having it join an interface to the group will "work", but I've seen several posts say that doing so may cause the socket to receive more UDP packets than the listener wants. Which I guess makes sense. Whereas many people say to bind the socket to the multicast group IP, but Microsoft says not to do that. <sigh>
  17. Remy Lebeau

    EIdReadLnMaxLineLengthExceeded Exception

    Not a good idea to send JSON in the query parameters. But, I suppose it is not forbidden either, so I should probably update TIdHTTPServer to handle that more cleanly, like sending a "414 URI Too Long " response instead of raising an exception. TIdHTTPServer already has a MaximumHeaderLineCount property (which raises an exception instead of sending a "431 Request Header Fields Too Large" response). I could add new MaximumUriLength and MaximumHeaderLineLength properties. I've opened a new ticket for these features: #474: Update TIdHTTPServer to handle long URIs and long request headers more cleanly OK
  18. Remy Lebeau

    EIdReadLnMaxLineLengthExceeded Exception

    That would work for TIdHTTP, but for TIdHTTPServer you would need access to its OnConnect event in order to update each connected client's IOHandler.MaxLineLength, and AFAIK WebBroker does not expose access to that event. But, I don't have any experience with WebBroker, so who knows...
  19. Remy Lebeau

    EIdReadLnMaxLineLengthExceeded Exception

    I suppose that is a possibility, but it is less common for a client to send a chunked request since that requires the client to have foreknowledge that the server actually supports HTTP 1.1 and chunked transfers before making the request.
  20. Remy Lebeau

    TIdIpMcastClient - Group join on second interface issue

    Makes me wonder if this is related to the following TIdIPMCastServer issue: #203: TIdIPMCastServer is missing a required call to setSockOpt for IPv6 In a nutshell, TIdIPMCastServer does not use the IPV6_MULTICAST_IF socket option to bind its outgoing sockets to any interface indexes. This seems to be required for sending, but is it also required for receiving? Indy does not currently support binding a socket to an interface index, only to an interface IP address. So, if binding to an index is needed in this case, you would have to manually perform SetSockOpt(IPV6_MULTICAST_IF) yourself, or maybe SetSockOpt(SO_BINDTODEVICE) instead. According to this post, it's also possible to bind a socket to an interface index by specifying the index as the Scope ID of the interface's IPv6 address, however Indy does not currently support scope IDs, either.
  21. Remy Lebeau

    EIdReadLnMaxLineLengthExceeded Exception

    How is your client sending the JSON request, exactly? What does the raw request look like? Indy's TIdHTTPServer (which TIdHTTPWebBrokerBridge uses internally) does not read body content line-by-line, only the request line and headers are read as lines, so you should not be getting a MaxLineLength error under normal conditions if the JSON is in the request body. Is the client sending the JSON in the URL query parameters instead, perhaps?
  22. Remy Lebeau

    IMAP using TIdIMAP4

    You are not supposed to use your secret keys as-is for the login token. You are supposed to use the keys to request an access token dynamically, and then use that token instead for login. NEVER give out your secret keys! Did you read the documentation I linked to earlier? Authenticate an IMAP, POP or SMTP connection using OAuth In particular, make sure you read the section titled "Get an access token". You are responsible for handling Steps 1 (which presumably you have already done) and Step 2 (the piece that is currently missing), and TIdIMAP4/TIdSASLXOuth2 will handle step 3 for you.
  23. Remy Lebeau

    Delphi 11 Community edtion

    Official blog announcement: https://blogs.embarcadero.com/delphi-11-and-cbuilder-11-community-editions-released/
  24. Remy Lebeau

    Version of Indy in D11.3??

    I do not know the exact GitHub commit that Embarcadero shipped, but it is in the 10.6.2 line. The initial Delphi 11.0 release was in September 2021, and for instance did not include a fix for this issue which was fixed in November 2021. I do not know whether or not Embarcadero has shipped newer Indy versions in Delphi 11.1-11.3. But you will definitely have an Indy version from the past couple of years at least.
×