Angus Robertson

I just told you, your application probably has the OnRequestDone event assigned, remove that and it will work properly. Angus

If your application has OnRequestDone assigned, then that will override TSslHttpRest.onHttpRequestDone so it is never called, that is a design flaw of mine which I will fix next week. Angus

Perhaps you are confusing two different events. OnRequestDone is an event raised by the base component TSslHttpCli and is handled in TSslHttpRest to process the body stream response into ResponseRaw. The OnRestRequestDone event is then called by TSslHttpRest and that is where the REST response should be processed. If your application uses OnRequestDone instead of OnRestRequestDone, no content will be available. > autorefresh token not work if app in Idle, eg minimized to tray? Windows applications continue to run when minimised, but not if Windows goes to sleep or is suspended by power management. Angus

Sorry, but if the component works correctly in the ICS sample application returning the correct information, there is no reason why it should not work in your own application, provided all the correct parameters are passed and you use the same events. Angus

> I have an old code that I'm trying to translate, make it work with ICS I'd suggest you look at the OverbyteIcsIpStmLogTst.dpr sample project in V8.60 which uses the new TIcsIpStrmLog component. This may be be configured as either a client or a server and allows you to send and receive data, hiding most of the complexity of setting up the SSL connection, so you just have an event where data arrives, and a function to send data. The sample behaves as a client or server, or both. Angus

slhtprest.RestRequest(httpGET, url, True, ''); The third parameter is 'AsyncReq: Boolean = False;' which you have set true so you making asynchronous requests still, as per your root message, But it is not clear from anything you posted whether you are waiting for a response to your requests, or assuming the content is available immediately the request starts and that function returns. Either change that parameter to false to make it a synchronous request which means it won't return until there is a response, or process the response in the OnRestRequestDone event as the demo application does. Angus

What is in ResponseRaw? Should be 236 bytes of data per the demo. If not, your code is different to the demo. Angus

ICS V8.60 has been released at: http://wiki.overbyte.eu/wiki/index.php/ICS_Download ICS is a free internet component library for Delphi 7, 2006 to 2010, XE to XE8, 10 Seattle, 10.1 Berlin, 10.2 Tokyo and 10.3 Rio, and C++Builder 2006 to XE3, 10.2 Tokyo and 10.3 Rio. ICS supports VCL and FMX, Win32, Win64 and MacOS targets. The distribution zip includes the latest OpenSSL 1.1.1 win32, with other versions of OpenSSL being available from the download page. Major changes in ICS V8.60 include: 1 - Added several new components and sample applications created by Magenta Systems Ltd over the past 17 years and previously distributed and installed separately to the ICS distribution. Bundling them with ICS makes installation and updating easier, and allows existing ICS samples to make use of many the new components, such as UTF-8 file logging. All the components have new names so existing applications using the originally distributed versions will still work, but it's recommended updating existing applications for the new ICS versions. The added components include IP stream logging, SMTP Mail Queue, Time Server and Client, Whois client, blacklisting of malicious IP addresses, file logging functions, file indexing, copying and deleting, FTP indexing, multiple file uploading and downloading, HTTP page parsing and URL downloading. 2 - In THttpCli, only follow relocation for 3xx response codes, not 201 Created, but keep Location property for 201 which is often response to a POST and may be needed by the application. 3 - When starting TWSocket Connect, the IP address chosen for DNS lookup is now saved in ASCII as AddrResolvedStr which is useful in connect OK or failed events to see whether an IPV4 or IPv6 address was chosen, and which was used if DNS offered multiple IPs. AddrResolvedStr is exposed as a property in TWSocket, THttpCli, TSslHttpRest and TFFtpClient and reports in failed connection events. Other clients will be added soon. 4 - Various samples have been updated to ease testing of IPv6 and to save the diagnostic window activity to a disk log file, OverbyteIcsHttpsTst, OverbyteIcsHttpRestTst, OverbyteIcsTimeTst, OverbyteIcsX509CertsTst. 5 - Added round robin DNS lookup if DNSLookup returns multiple IP addresses, so they are used in turn after a failure when a component is called repeatedly without being freed. This is implemented in THttpCli, TSslHttpRest TFFtpClient and TIcsTimeClient. Other clients will be added soon. There is a new OnSelectDns event to override round robin lookup and make your own choice. By default, the DNS lookup in ICS components ignores IPv6 addresses and always use the first IPv4 address offered, when there is more than one. This is usually implemented in the OnDnsLookupDone event in the application or high level component. So if that first address does not respond, the application never tries any other addresses. This has become more of a problem when enabling applications for IPv6, by changing SocketFamily from the default sfIPv4, to sfAny, sfAnyIPv4 (prefer IPv4), sfAnyIPv6 (prefer IPV6) or sfIPv6 (only IPv6), when IPv6 addresses may also be returned as well as IPv4. Due to routing or firewall issues, IPv4 and IPv6 might not both be available and so connection will fail if that address is chosen first. Previously it was necessary to restrict SocketFamily so only the working family is attempted. The DNS round robin implementation relies on keeping the last successful connected IP address, so it can be re-used for subsequent connections, but looping through any alternative addresses if the last connection failed, for subsequent connection attempts. Most existing applications use the OnDnsDone event to select the connection IP address so the round robin code is added there. Newer applications making use of TWSocket ComponentOptions wsoAsyncDnsLookup should added code in OnDNSLookupDone and update the DnsResult property which is then used by Connect. 6 - IcsHosts supports two new TSslSrvSecurity server security levels, sslSrvSecTls12Less and sslSrvSecTls13Only, the former disables TLS1.3 in ICS servers if TLSv1.3 fails (perhaps a bad client implementation) while the second only supports TLSv1.3. 7 - Up to date C++ packages are included for 10.2 Tokyo and 10.3 Rio. Information on installing ICS for C++ 2007 may be found at: https://en.delphipraxis.net/topic/844-use-ics-with-c-builder-2007/ Sorry, currently don't believe it's easy to update the ICS source code to avoid the changes needed for C++ 2007. Full release notes are at: http://wiki.overbyte.eu/wiki/index.php/ICS_V8.60 Angus

The V8.60 zip and overnight zip are both now updated, and will again build on recent compilers. Angus

Both requests seem to work, they both return 200 success and the same length content, so it would appear you are not correctly reading the JSON data returned by the server. The Authorization header is different in the two requests, despite both requests seemingly being successful. Angus

Most of those values you will set according to the requirements of your application, they are self explanatory from the fields on the sample application, but you won't need username and password with OAuith2. As requested previously, if you expect help debugging your application, you need to post the request and response headers ICS sent and received, not just tell us it did not work. Angus

Sorry, made last minute change to make that unit OS-X compatible, but did not check it properly, will update it shortly. Meanwhile, just change WinApi to System on the two lines with SysUtils errors. Angus

On the REST sample Settings tab, you select Debug Logging as 'HTTP Header' or 'HTML Body', and the headers appear in the log window. The latest version in V8.60 adds a Log Directory field which also write the window to a disk log file, if specified. Angus

The sample logs all the request and response headers, we need to see those to explain why you get a 400 error. Angus

As Allen said, you spelled Authorization wrong, one reason to use the new property rather than write your own headers. Also you are using async methods but not waiting for a response, you should use sync methods if you want a simple application. Exactly what header responses do you get with the correct spelling. Angus

I added a new component TSslHttpRest in V8.58 which makes several of your lines redundant, look at the new sample project OverbyteIcsHttpRestTst which also illustrates OAuth2. Also, TSslHttpCli has a new property THttpAuthType that adds httpAuthBearer and httpAuthToken, and AuthBearerToken for OAuth so you don't need to use ExtraHeaders. Angus

I'm trying to update the new C++ packages for all the units added in V8.60, I thought successfully, except I'm unable to add DCR and PAS units with the same name to IcsVclBCB, I can add or the other, but get duplicate dialogs when added both together or one subsequently. Yet the package already correctly contains PAS/DCRs for lots of other units. Editing the XML manually is a pain due to the BuildOrder tag. Amazingly, without the DCRs I have managed to build the C++ packages, after removing all Delphi packages. Angus

EmptyStr will not compile in Delphi 2007, needs a constant not a string in declarations. Could be done with dozens of conditional lines since this effects several units. Angus

Don't worry about the EmptyStr change, I'm doing it for several units at the moment. Angus

OK, I see that default, it is not important and can be changed. But numerous other functions and procedures in ICS have default parameters, they are very useful. Surely C++ is not objecting to all of them? Angus

Sorry, I can not find any lines in that unit that match your comments. the word unknown does exist in the unit. If you need to make changes to keep an old compiler happy, please change the SVN version of the unit and email it to me. And those changes must be backward compatible. Angus

Sorry, as discussed elsewhere in this forum, we don't support those old C++ packages at the moment, due to lack of C++ knowledge. I want to remove, them, but other users manage to get them to build. Angus

Many thanks, uploaded to SVN, will be zipped overnight about 11pm. The readme will be updated soon. Angus

Sorry no idea, I don't do C++ and the C++ packages are unsupported. Angus

I'm using Firefox, but no spelling. I have 'check your spelling as you type' checked. Later, installed a British dictionary and Spelling now appears on the right click menu. I thought better web applications used Ajax for spelling nowadays. Angus