Jump to content

Angus Robertson

Members
 View Profile  See their activity

  • Content Count

    1745

  • Joined

  • Last visited

  • Days Won

    33

Posts posted by Angus Robertson

  2. Posted

    Quote

    Where is the blocking function ?

    Also wouldn't be nice to have a timeout for that ? 

    Reverse DNS is WSocketResolveIp, forward DNS is WSocketResolveHost, blocking means no timeout is possible, unless you mess with registry settings that affect every other application on the PC. 

     

    Angus

    • Like 1

  3. Posted

    ICS deliberately does not offer sync version of the low level Winsock functions, only high level protocols like HTTP and FTP. 

     

    There is a blocking version of DnsLookup, but no timeout is possible since the OS function waits up to 30 seconds or more for DNS servers to respond to queries, So you need to implement your own abort on timeout.  Or use the TDnsQuery component

     

    Angus

     

  6. Posted

    ICS is mostly even driven, you never put delays in events since that upsets the protocol. 

     

    So it's really down to how you queue your emails, delay sending them after an error, I mostly use triggers tested in a single once per second timer event, there are several functions in ICS for setting and checking triggers.  Except for TIcsMailQueue which uses real date/times checked in a thread.

     

    How many emails (megs) are you sending each minute?  It must be a lot to cause the mail server queue to run out of disk space continually. 

     

    Angus

     

  7. Posted

    Agree, essentially nothing to fix in ICS, it's a server issue, Google brings up a vast number of responses for the error in Exchange.  Hard to tell if it's a real problem with the server being overwhelmed or artificial because it considers the email volume abusive. 

     

    Restarting your service merely causes a delay in sending email so the server is content again. 

     

    So you need to slow down the rate at which you send emails.  Perhaps send one email per session, if you are sending multiple emails with one connection, Or just wait a second or two between emails, If you get an error sending email, close the session and start a new session.  Much easier to test if you have access to the real server.

     

    Are you using the TIcsMailQueue component?  It is designed for this sort of activity and will retry emails that fail on a schedule over many hours.  But it does not currently have a means to so down flow to one server.   It will use multiple servers if one gives an error.

     

    Angus

     

     

     

     

     

    • Like 1

  10. Posted

    9 hours ago, HTMLValidator.com said:

    Although my 64-bit app builds are crashing (32-bit works)..

    There were a lot of low level changes relating to destroying components this week in SVN that have made some of my Win64 applications a lot more stable.  You might want to try the overnight zip.   And more HTML changes due shortly. 

     

    Angus

     

  11. Posted

    The IcsShellExec function moved units in V8.69, it is now in OAuth, but perhaps you have an old HttpRest unit with it still in?  Or an old DCU.

     

    When installing a new version of ICS, it's always safest to use the Build Group pane to build all four versions of all packages, just wish it installed them as well. 

     

    Angus

    • Like 1

  12. Posted

    ICS has never been available from GitHub, someone must have stolen it and reposted it there without permission. 

     

    We use a private SVN server, https://svn.overbyte.be/svn/ use the ICS branch. 

     

    But I prefer to add patches using WinMerge comparing complete old and new units (no diffs), so please email complete units with your new code commented so I know why it is there.  My email is in various ICS units and the readme.

     

    I suggest you look at the OverbyteIcsHttpProt,pas unit in SVN today, there were a many changes yesterday from another contributor. 

     

    Angus

     

  13. Posted

    I've started converting ICS VCL sample applications to FMX, using VCLToFireMonkeyFormConvtr.exe from: http://www.innovasolutions.com.au/delphistuf/ADUGVCLtoFMXConv.htm

    or  https://github.com/rogerinnova/Delphi-Firemonkey-Dunit

     

    It is very basic, search and replace using an INI file, not looked at the Github version, but the zip download was for XE5 and the INI file needed several changes to bring to cope with the latest FMX forms.  I mapped TListView to TStringGrid, TRadioGroup to TListBox, TBitBtn to TButton, TComboBox to TComboEdit, TRichEdit to TMemo, TPageControl to TTabControl, and a few other things.   TGrid would be better than TStringGrid, except it uses virtual data (which the help fails to mention) which needs a lot of rewriting. TRadioGroup is the biggest problem, visually you can do it, but there is no simple ItemIndex to use, so TListBox with or without a separate caption is easier.  

     

    I can share my INI file is anyone wants it, but it's a work in progress, several more samples to convert.

     

    Angus

     

  15. Posted

    ICS will shortly have a new websocket (WSS) client component. 

     

    One of our long term users has kindly contributed code extracted from a working application and a new test application which works, it will take me a few days to check throughj the source and test it thoroughly.  I will then also look at our existing websocket server which is very old code, and try to bring that up to date with SSL/TLS. 

     

    Angus

     

    • Like 3

  16. Posted

    Server sockets tend to only raise errors when they are processing data, not sitting idle listening. 

     

    There are really only two solutions, send wake up data periodically to the server socket, or check a last received time stamp if you expect data every five minutes or something, or perhaps a combination of the two.   

     

    Wake up testing can be added with a few lines of code using TSslHttpRest for HTTP or TIcsIpStrmLog for simple ASCII which I believe HL7 uses.  I had a problem with one of my web servers not listening after restart and added this in half an hour.  Then discovered I was incorrectly setting a firewall rule on startup. 

     

    If TWSocket has stopped listening, you can try closing and re-opening, but it's safer to restart the application, which is easy with a Windows service, just set service properties to restart after five seconds, and stop it.  My servers send an email when this happens so I know to check the logs for why, the OverbyteIcsDDWebService sample illustrates this. 

     

    Angus

     

     

     

  17. Posted

    There are simple ways to download a file with zero error handling, and proper ways. 

     

    Without error handling, unexpected things can happen.  My PC crashed out of disk space a few weeks ago.  Eventually I discovered the Sage accounting software had downloaded 11,000 copies of a tmp file, totalling over 400 gigs, over a couple of days, in background.  No error handling and a lousy design, expected better from a company that charges hundreds of pounds to get a new software version that supports TLS/1.2. 

     

    Angus

     

    • Like 1

  18. Posted · Edited by Angus Robertson

    Don't often look at map files, but you are correct, the TRestOAuth object and new OAuthForm are being dragged into the ICS web server sample. 

     

    I don't believe OAuth is referenced anywhere, but all units using TSslSocketServer bring in TSimpleWebSrv to handle automatic SSL/TLS certificate ordering, and that that is in the same unit as OAuth.  Unless you un-define AUTO_X509_CERTS. 

     

    I've been under the impression for 20 years that Delphi only linked in objects that are actually referenced and ignores unused ones in shared units, but perhaps that has changed?  And maybe that is why applications built with new versions of Delphi become bloated in size. 

     

    If linking is broken, I could move TSimpleWebSrv back to the REST unit (where OAuth used to be) or to a separate unit. 

     

    I try to avoid lots of small units to simplify maintenance and needing to change over 100 runtime packages each time I add a new unit, but that has to happen for the next ICS release to add the new OAuth forms. 

     

    Update: looking at some code, the OAuth stuff is being brought in to support automatic SSL/TLS certificate ordering from a German company CertCentre who sell Sectigo and DigiCert certificates, whereas most people probably only need Let's Encrypt.  I'll look at making CertCentre conditional. 

     

    Angus

     

  20. Posted

    Looking into the strange host name ws.twelvedata .com posted here, in UTF-8 it is \x77\x73\x2E\x74\x77\x65\x6C\x76\x65\x64\x61\x74\x61\xEF\xBB\xBF\x2E\x63\x6F\x6D which includes a special symbol before the second dot, in UTF-8 xEF\xBB\xBF\ or #65279, which is the non-printing reserved Unicode symbol range. 

     

    So you can not see it, but it copies and converts into an international domain name (like Chinese).  Potentially a risk for phishing, but no idea how it got into the original wss URL.

     

    Angus

     

  21. Posted

    I suspect your URL contains non-ASCII characters that look like ASCII, often used by phishers to hide fake URLs, but can happen for other reasons.

     

    When I first tried ws.twelvedata.com ICS gave the error 'Cannot convert host address 'ws.xn--twelvedata-lb99c.com' - Host not found ' (as your screen short) which means the host name contains illegal characters and has been translated into ASCII, note the xn- part which is the giveaway.

     

    When I retyped it as ws.twelvedata.com I can connect okay on port 80. 

     

    Angus

     

  24. Posted

    Sorry, VCLZipPack seems to slipped back into OverbyteIcsD2007Run.dpr/dproj with the changes to remove it in V8.70 from more recent compilers.  Just remove it and the package should rebuild, You may have to also fix a missing variable in another old unit. 

     

    I've now disabled VclZip from my master copy since I'm no longer using it now ICS supports TZipFile, so this should not happen again...

     

    These changes are now in SVN.

     

    Angus

    • Thanks 1

  25. Posted

    Originally it was considered allowable for native applications to display an embedded browser window in the application to capture the Authorization Code during redirect.  But that potentially means the application can also capture the login as well so is no longer best practice, see RFC8252, and some apps will block the embedded window.  The preferred authorization method is for the native application to launch the standard browser and redirect to localhost where a small web server runs to capture the Authorization Code.

     

    When OAuth2 was originally added to ICS, the only embedded browser available in Delphi was TWebBrowser using Internet Explorer, which Microsoft had announced was being removed from Windows and Google was ceasing to support.  So ICS initially only supported the standard browser for authentication using a local web server. Since then Delphi 10.4 added the embedded TEdgeBrowser Chromium based browser and despite MSIE disappearing TWebBrowser still seems to work, so ICS now also supports both as Embedded Browsers, to provide a better user experience during authentication, with the window closing automatically and not needing a local web server (that may be blocked by a firewall). Earlier Delphi versions will support TWebBrowser but this no longer works with Google, so applications should still allow the standard browser to be used.  Edge Chromium can be installed on Windows 7 and later. The form checks for Edge in the registry and for the WebView2Loader.dll, otherwise uses TWebBrowser.

     

    Officially the Microsoft.Web.WebView2 runtime (from GetIt) must be installed for Edge Chromium to work, but in practice copying WebView2Loader.dll into the same directory as the executable seems to work, there are Win32 and Win64 versions of this DLL with the same name, you need the correct version for the build!

     

    SVN and the overnight zip have a new ICS beta with the new window, it is currently only supported for Delphi 10.4 and 11, VCL only, later betas will add TWebBrowser for old Delphi versions and FMX.

     

    Any feedback on the new window cosmetics and it's operation would be appreciated before this is finally released. All three SSL samples for sending and receiving email have been updated with the new window.

     

    Angus

     

    • Like 3
×