Possible memory leak

[djxandytche 0]

Hello,
 

First of all I'd like to congratulate you on the excellent work you've done on P4D.
Secondly, I want to apologize for my bad English (I'm Brazilian and I'm using Google Translate to help).
 

I'm studying and testing P4D and I came across a situation that I couldn't understand.
The situation is a memory leak that occurs whenever the "ExecString" method is called to execute any script.
 

To simulate it, just do this simple example:

procedure TForm1.Button1Click(Sender: TObject);
var
    i: Integer;
begin
    for i := 1 to 1000 do
        GetPythonEngine.ExecString('print("hello")');
end;

I'm using Delphi 11.1 and compiling for 64-bit Windows.

For every 1000 scripts executed, memory consumption increases by about 0.5 MB.
In software that runs 100000 scripts per day, memory consumption could increase by around 50 MB per day.
I intend to use P4D in the software of the company I work for and in most cases it will exceed 100000 scripts executed per day and the executable will be running 24x7.
Considering this, I believe that at some point the memory may reach its limit.

Is there anything I can do to free up the memory consumed by each call to the "ExecString" method?

Thanks,

Alexandre da Silva.

[pyscripter 694]

Clear the output?

[djxandytche 0]

Hi,

Do you mean capturing the output via "TPythonGUIInputOutput"?
If so: I'm not even using it.
I've made the code as simple as possible. See below:

Unit1.pas:

unit Unit1;

interface

uses
  Winapi.Windows, Winapi.Messages, System.SysUtils, System.Variants, System.Classes, Vcl.Graphics,
  Vcl.Controls, Vcl.Forms, Vcl.Dialogs, Vcl.StdCtrls, PythonEngine;

type
  TForm1 = class(TForm)
    PythonEngine1: TPythonEngine;
    Memo1: TMemo;
    Button1: TButton;
    Label1: TLabel;
    procedure Button1Click(Sender: TObject);
  private
    { Private declarations }
  public
    { Public declarations }
  end;

var
  Form1: TForm1;

implementation

{$R *.dfm}

procedure TForm1.Button1Click(Sender: TObject);
var
    i: Integer;
begin
    for i := 1 to 1000 do
        GetPythonEngine.ExecString('print("hello")');
end;

end.

Unit1.dfm:

object Form1: TForm1
  Left = 0
  Top = 0
  Caption = 'Form1'
  ClientHeight = 234
  ClientWidth = 351
  Color = clBtnFace
  Font.Charset = DEFAULT_CHARSET
  Font.Color = clWindowText
  Font.Height = -12
  Font.Name = 'Segoe UI'
  Font.Style = []
  TextHeight = 15
  object Label1: TLabel
    Left = 8
    Top = 8
    Width = 73
    Height = 15
    Caption = 'Python script:'
  end
  object Memo1: TMemo
    Left = 8
    Top = 29
    Width = 185
    Height = 89
    Lines.Strings = (
      'print("hello")')
    TabOrder = 0
  end
  object Button1: TButton
    Left = 8
    Top = 124
    Width = 185
    Height = 25
    Caption = 'Run 1000 times'
    TabOrder = 1
    OnClick = Button1Click
  end
  object PythonEngine1: TPythonEngine
    Left = 112
    Top = 48
  end
end

Is there something else I could be doing wrong?

[pyscripter 694]

This was a python reference counting issue.

Fixed in version control.

Please try the latest version and confirm the issue is solved.

[djxandytche 0]

That was it!
I updated, tested and now the memory leak no longer occurs.
Thank you for your help!

[AndreasSt 0]

Hello, I am using p4d from getit in Delphi 12.1. I do not know which version of p4d this is. There is no update notice in the getit manager.

But when executing a simple script, each call increases the memory of my sample app. Does anybody know if the bug fix is done in the version from getit in 12.1?

Or should I use p4d without getit and install/update it another way?

Thanks a lot

[pyscripter 694]

The GetIt version is created by Embarcadero based on a p4d fork.   Eventually the fixes will be added to the Embacadero fork, but then it may take some time for the GetIt installation to be updated.    Using the pyscripter/python4delphi: Free components that wrap up Python into Delphi and Lazarus (FPC) (github.com) repo will probably get you the latest fixes much faster.

[AndreasSt 0]

Thanks for the fast reply. I now have uninstalled p4d from getit and reinstalled it. Now the Timestamp in getit for p4d is 27Aug 2024. So perhaps it comes with newer sources than my installation before. (the result in my app was the same as before, memory cosumption increases everytime I call the execution of the script) So now I will try the other way you mentioned to be sure that I am not hunting an issue already fixed.