Issue in TIcsFtpMulti component

[nemifoy5261 0]

Recently, while viewing the code of the TIcsFtpMulti component (ICS V9.0), I discovered that the IntUpOne function of this component could potentially throw an "Invalid pointer operation" error.

When the "Zipping" Conditional is defined and the component's "Zipped" property is set to True, the component will compress files before uploading.

If, under certain circumstances, the relevant code within the IntUpOne function, specifically the FtpCheckFile call, does not execute or executes incorrectly, leading to the failure to set LocalStream to nil, then the code within the outermost finally block of the IntUpOne function that releases LocalStream and MyArchiveStream will throw an "Invalid pointer operation" error.

[Angus Robertson 577]

Thanks, I'll attempt to reproduce those conditions to see if I can reproduce the error, then fix it, for the next release.

 

Zipping did get changed recently to support the native component, and I don't use zipping myself much nowadays.

 

Angus

 

Edited November 14, 2023 by Angus Robertson

[nemifoy5261 0]

First of all, thanks for your reply.

 

In fact, this exception is catched and won't cause other problems.

I just feel that the code implementation here isn't quite "graceful" and this issue might become a "bomb" buried in the code in the future.