Advice for Compiling Github Indy under Delphi 12

[David Robb 0]

In case anybody had trouble getting the Indy packages to compile, note that there is a copy of IdCompilerDefines.inc in Lib\Core, Lib\System and Lib\Protocols and each one needs to be edited by adding the following below the VER350 compiler define:

 

  //Delphi & CBuilder 12.0 Athens
  {$IFDEF VER360}
    {$DEFINE VCL_11}
    {$IFDEF CBUILDER}
      {$DEFINE CBUILDER_12}
    {$ELSE}
      {$DEFINE DELPHI_12}
    {$ENDIF}
  {$ENDIF}
 

 

Edited March 1 by David Robb

[Remy Lebeau 1421]

1 hour ago, David Robb said:

In case anybody had trouble getting the Indy packages to compile...

I'm guessing you didn't see https://github.com/IndySockets/Indy/pull/517 yet?

 

In any case, I'm also working on my own update to Indy for D12, but that update also includes bringing Indy's Package Generator up-to-date, which is why I haven't merged the above PR yet, as I want to see how the generated files compare to the PR's files.

 

Although, I guess at this point, I should just merge the PR and then merge in any generator diffs later...

Edited March 1 by Remy Lebeau

[David Robb 0]

Thank you for your response, Remy, I will download that PR!

[Remy Lebeau 1421]

5 hours ago, David Robb said:

Thank you for your response, Remy, I will download that PR!

I just now closed the PR and checked in my own changes for Delphi 12.