bug in OverbyteIcsWSocket.pas.DataToString()

[merijnb 4]

Hey all,

 

See this function in OverbyteIcsWsocket.pas

P should be an PAnsichar here (I'm guessing this function is older then Delphi 2009 and never updated).

 

{* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *}
function DataToString(Buf : Pointer; Len : Integer) : String;
var
    P : PChar;
begin
    P      := PChar(Buf);
    Result := '';
    while Len > 0 do begin
        if Word(P^) in [Ord(#32)..Ord(#126)] then
            Result := Result + P^
        else
            Result := Result + '$' + IntToHex(Ord(P^), 2) + ' ';
        Inc(P);
        Dec(Len);
    end;
end;

 

[Angus Robertson 608]

Thanks, now fixed, That function is only used for diagnostic dumping of SSL packets, which I never use due to massive logs. 

 

Angus