WSSendBinaryStream usage

[sfrazor 3]

When calls to WSSendBinaryStream happen, I'd like to verify the contents went and are not buffered.  If even does buffer (for the lack of a more precise term).  
if WComms.IsConnected
   WSSendBinaryStream(nil,Outdataa);

I have events for OnSocketError and OnBGException and onWSFrameSent, checking AFrame.bytes.

I am sending 3 4M files back to back.   It looks as though all files were sent but after the first file sends and fires the on onWSFrameSent event, the last two files don't fire the event but I don' see any errors.  Its like they are buffered or staged.
If I send them again, the previous 2 files will send and fire the event, but it leaves 2 more either buffered or???  
Sometimes all 3 files send, sometimes 2 etc.....  But a fresh send will push the prefvious out and fire the onWSFrameSent.

 

How can I verify all 3 frames were sent and if not, flush any remaining or resend?  

 

Regards

 

Update:  If I send the files one at a time, they transfer fine.  In a loop, sending back-to-back seems to be the issue.

 

Edited March 7 by sfrazor
Update

[Angus Robertson 625]

Sorry, no idea off hand, not used Websockets for sending large binary blocks, only simple ANSI/HTML packets. 

 

Reproducing your scenario is not trivial and would take some effort, I'll put it on my list, but it might take a while.  Are both server and client ICS WS apps?

 

Angus

 

[sfrazor 3]

4 minutes ago, Angus Robertson said:

Sorry, no idea off hand, not used Websockets for sending large binary blocks, only simple ANSI/HTML packets. 

It works really well for one file at a time.  🙂  Its like its not ready to send when I call the WSSendBinaryStream in a loop but it takes in the data in to a buffer and it sits there.  It seems out of sync with the socket state.   Its like I need to wait for a state like httpready or something before I call the send.

4 minutes ago, Angus Robertson said:

Reproducing your scenario is not trivial and would take some effort, I'll put it on my list, but it might take a while.  Are both server and client ICS WS apps?

The server is a python server running Flask utilizing websockets.  The server has been solid for some time but that doesn't mean there is not an issue.  Its like the ICS client isn't receiving an ACK from the last frame sent, if it was infact sent  Or the Comms is not in the right state.    Or the entire cycle is too fast to process.....  Slowing it down with sleeps in between doesn't seem to have any effect.....  But I'm not sure how to verify the socket is in the ready-to-send state.

I don't hink its fair to ask you to reproduce the client and server.  So instead just give this some thought and get back if you come up with something that would be a worth try.  I'm still working at it on my end.

Again I have to apologize.  Everything I do is on an air-gapped network so poulling code over is often not possible.

 

Thank!

 

Regards

[sfrazor 3]

Angus,
In a previouse quesiton I asked about high CPU usage.  We found that MsgWaitForMultipleObjects worked to resolve the issue.  but sleep(0) did not.

I tested with single files and transfer speeds were great and CPU was normal.

In my mutiple file send scenario, if I remove the MsgWaitForMultipleObjects  and let the CPU run at ~50 percent in that main loop, all of the files transfer without issue.  No other code changes.

I'm really at a loss.  
Some more info...   after every call to any kind of socket IO I immediately call processmessages.  SInce this is a console app and will eventually be a DLL the messages need to be addressed.  This is something else you pointed out to me some time back.
The file send is in its own thread looking for the existence of files, reads them and sends them.  Nothing magical.  There is a Sleep(5000) inbetween checks.

Edited March 7 by sfrazor

[Angus Robertson 625]

I'd make the general point that ICS is an async library, generally you should never use Sleep(), but events.  If you want to delay something, use triggers within a timer.  Having multiple ProcessMeesages everywhere is also bad design.  

 

Your code should be packaged into an object with events, called before a single message loop.   In fact, this design would mean you can test and debug your WS code in a simple GUI before using it in a DLL. 

 

From your various comments, I gather you are writing a Websocket client DLL that sends large binary blocks of data to a server, All my testing and the ICS samples are server to client communication, although in theory the code is two-way and similar in client and server.  But I simply don't have a way to easily test your requirement.

 

Angus

 

[Angus Robertson 625]

I've added a new event OnWSFramesDone to the Websocket client, called when the queue of frames has been sent, for flow control when sending a lot of data. Previously, the OnWSFreameSent was called after each frame, but it was not easy to tell if this was the last queued frame.  

 

I've only tested it with a few frames of ASCII, the HttpRest sample really needs a new button to send a queue of files, which is on my list, but also needs a server able to accept those files.  But I'm sure you'll tell me if it does not work.  In SVN now, will be zipped overnight.

 

Angus