C:\ProgramData\ICS-OpenSSL folder

[EugeneK 28]

Hi

 

I just randomly noticed this folder C:\ProgramData\ICS-OpenSSL on customers machine and then found this code in OverbyteIcsLIBEAY.pas 

 

// create OpenSSL public directory is missing, usually created when installing packages or application installer
    ForceDirectories(GSSL_PUBLIC_DIR);

 

can we please not do it, or at least provide some conditional define to avoid it  it is not a good idea to pollute public folders with random files for no reason.

[Angus Robertson 662]

ICS does not put random files into that directory, it extracts the OpenSSL DLL files there, as explained in the readme9.txt file.  Using a common directory, means all ICS applications share the same DLLs, unlike a couple of years ago where ICS applications typically had DLLs in multiple directories that were a pain to update for new versions.  

 

If you are not using OpenSSL, don't include that unit.  If you are using OpenSSL and don't want that directory or prefer to specify your own directory, the readme explains ways to change it, but these are not extensively tested or used.  You will then become responsible for distributing the OpenSSL DLLs, somewhere. 

 

Angus

 

[EugeneK 28]

3 hours ago, Angus Robertson said:

ICS does not put random files into that directory, it extracts the OpenSSL DLL files there, as explained in the readme9.txt file.  Using a common directory, means all ICS applications share the same DLLs, unlike a couple of years ago where ICS applications typically had DLLs in multiple directories that were a pain to update for new versions.  

 

If you are not using OpenSSL, don't include that unit.  If you are using OpenSSL and don't want that directory or prefer to specify your own directory, the readme explains ways to change it, but these are not extensively tested or used.  You will then become responsible for distributing the OpenSSL DLLs, somewhere. 

 

But can it be created only if it used, I manage my own OpenSSL installation and don't use this folder, so there is no reason to create it.

[Angus Robertson 662]

So which defines have you changed? 

 

As I said, you can set GSSL_PUBLIC_DIR to your own directory, which won't be created if it exists.   Not creating it on startup will add a lot of extra checks to the code.  

 

Angus

 

[EugeneK 28]

10 hours ago, Angus Robertson said:

So which defines have you changed? 

 

As I said, you can set GSSL_PUBLIC_DIR to your own directory, which won't be created if it exists.   Not creating it on startup will add a lot of extra checks to the code.  

I've undefined OpenSSL_Resource_Files and OpenSSL_ProgramData, Can folder be created only if either or both of these is set?