ICS 8.62 - Proxy settings override to httpAuthBasic when using FProxyURL

[Kyle_Katarn 1]

{ V8.62 if proxy URL is passed, parse it as proxy properties }
    { http://[user[:password]@]host:port }
    if (Length(FProxyURL) > 6) and (Pos (':', Copy(FProxyURL, 6, 9999)) > 5) then begin
        ParseURL(FProxyURL, Proto, User, Pass, Host, Port, Path);
        { pending, check https for SSL prpoxy, maybe socks for socks proxy }
        if Proto = 'http' then begin
            FProxy := Host;
            FProxyPort := Port;
            FProxyUsername := User;
            FProxyPassword := Pass;
            if (FProxyUsername <> '') and (FProxyPassword <> '') then
                FProxyAuth := httpAuthBasic;
        end;
    end;

Wouldn't it be wiser to do FProxyAuth := httpAuthBasic; only if FProxyAuth = httpAuthNone ?

Otherwise, if user has selected httpAuthNtlm (or other) then settings is lost and non-overridable

 

Likely minor issue (and this may help me to solve my other issue by forcing basicAuth)

[Angus Robertson 577]

ProxyURL is not designed to work with httpAuthNtlm, don't use it and there is no problem.

 

httpAuthNtlm uses Windows credentials, that is the whole point of it.   

 

Mind another ICS user made changes that might be the cause of your problems:

 

Apr 09, 2019 V8.61 OAS : Improved NTLM authentication by adding Single Sign On with NTLM Session on Windows Domain to get credentials without needing them specified here.
 

Angus

 

[Kyle_Katarn 1]

Well done, that's likely the cause !

Any possibility to fix or roll back ? Do you have a bug/change tracker somewhere ?

Thanks !!

[Angus Robertson 577]

Why would I roll that back, it's nothing to do the proxy support.  And you said you are not using NTLM.

 

Angus

 

[Kyle_Katarn 1]

Sorry, I thought this could be the cause of the NTLM errors reported here :