OverbyteIcsLIBEAY.pas: f_CRYPTO_get_ex_data should return Pointer, not Integer

[Ralf Junker 1]

f_CRYPTO_get_ex_data should return Pointer, not Integer. The code in question is at OverbyteIcsLIBEAY.pas line 1847, SVN 1476:

f_CRYPTO_get_ex_data: function(r: PCRYPTO_EX_DATA; idx: integer): integer; cdecl = Nil;

The corresponding C declaration from OpenSSL's crypto.h:

void *CRYPTO_get_ex_data(const CRYPTO_EX_DATA *ad, int idx);

Suggested solution:

f_CRYPTO_get_ex_data: function(r: PCRYPTO_EX_DATA; idx: integer): Pointer; cdecl = Nil;

Reference: https://www.openssl.org/docs/man1.1.1/man3/CRYPTO_get_ex_data.html

 

Ralf

[Angus Robertson 574]

The CRYPTO_get_ex_new_index and similar functions have never been used by ICS.

 

Angus

 

[Ralf Junker 1]

Quote

The CRYPTO_get_ex_new_index and similar functions have never been used by ICS.

Agreed. But maybe they are used or will be used somewhere else?