Jump to content

David Heffernan

Members
  • Content Count

    3586
  • Joined

  • Last visited

  • Days Won

    176

Everything posted by David Heffernan

  1. David Heffernan

    TPainBox, Handle and PostMessage()

    Invalidate doesn't send a message. It marks the control as needing repainting and then that paint message is synthesised the next time the message queue is emptied.
  2. It's a shockingly bad way for a software house to prioritise. It's susceptible to an effect known as self selection. As worthwhile as a Twitter poll.
  3. David Heffernan

    TPainBox, Handle and PostMessage()

    No. That's not what Invalidate does. It marks the paint box as invalid. And then when the message queue is next empty, a paint event gets synthesised. The thing is, at some point you need to make the main thread wake up and do something. What's your plan for doing that? Perhaps what you want to do is note that an update is required with a flag and then check that on an update timer in the main thread. That would be a sensible approach if the frequency of updates from the threads was very high. Bear in mind that in the OP you suggested sending a message from the worker thread to the main thread. Have you now decided that you don't want to do that?
  4. David Heffernan

    TPainBox, Handle and PostMessage()

    Dude, it was you that wanted to have the worker thread notify the main thread! That's literally what you asked in the OP. Why would you opt to send a message to the parent? I only said that because you can't send a message to the paint box since it isn't windowed. Which is why Queue or Synchronize are cleaner. Ultimately, you need to call Invalidate on the paint box, from the main thread. And you need to decide what is going to trigger that to happen. I gave you some examples, and of course there are other ways. But your have to make you own mind up.
  5. David Heffernan

    TPainBox, Handle and PostMessage()

    You'd have to post the message to the parent. But why bother. Just use TThread.Queue.
  6. David Heffernan

    TPainBox, Handle and PostMessage()

    Use TThread.Queue, not least because the paint box isn't windowed.
  7. David Heffernan

    TPainBox, Handle and PostMessage()

    You never send a WM_PAINT message to a control. You invalidate in. For a plain Win32 control that means calling InvalidateRect. For a VCL control that means calling Invalidate. You don't want to call that from a thread. Use Synchronize to execute code on the UI thread.
  8. David Heffernan

    You RAD Studio 10.4 Sydney appreciated features and bug fixes

    On the plus side these can be readily fixed yourself for your programs. I mean, I've been running with a patched RTL for years that fixes all the design flaws in handling of floating point control flags. At least we have access to the RTL source code and so can apply fixes easily using code hooks.
  9. David Heffernan

    Front-end vs Back-end question

    Depends on all sorts of things. I guess people are finding it hard to get motivated to write it all down.
  10. This sounds like a whole layer of extra complexity for no gain. Frankly I'm not surprised that you seem to find everything so challenging when you choose to introduce layer on layer of complexity.
  11. David Heffernan

    Remote control of Word no longer working

    Nah, that's not true.
  12. David Heffernan

    Remote control of Word no longer working

    Automating Word for document preparation is known to be somewhat brittle. More robust is to generate Word documents directly without invoking Word at all. There are good libraries for doing that. That's the point. If you are going to rely on Word for this then it pays to be very careful about the version that you use. Switching to Office 365 is simply asking for trouble.
  13. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    OK. I've been working to the definition in the Delphi RTL.
  14. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    Wrong. It returns a Bool, which is LongBool, the 4 byte boolean. The right fix is for Emba to change it to Boolean.
  15. David Heffernan

    Detect Windows shutdown?

    You can't have read the documentation. Because you aren't calling ShutdownBlockReasonCreate. I know that you want to solve this quickly. But that expectation is unrealistic. It will take you time to wade through this, try it out, read and understand example code, etc. For sure one of us could write you some examples but unless you understand it will you really be able to integrate it into your code? Just because you don't understand this now does not mean that you can't learn it. It just requires self belief and persistence.
  16. David Heffernan

    Detect Windows shutdown?

    You aren't doing what the documentation I linked to instructs you to do.
  17. David Heffernan

    Detect Windows shutdown?

    Getting notification isn't really what concerns you. You know how to do that. What you need to be able to do is block shutdown until you have finished saving any data. The way that is handled changed in Vista. The documentation you need starts here: https://docs.microsoft.com/en-us/windows/win32/shutdown/system-shutdown
  18. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    It's astonishing that Emba's InterlockedCompareExchange128 returns a BOOL, i.e. a 4 byte boolean, LongBool. They are presumably trying to copy this one from MS https://docs.microsoft.com/en-us/windows/win32/api/winnt/nf-winnt-interlockedcompareexchange128 which is actually implemented as an intrinsic. But look at the MS function's return type. Yup, it's BOOLEAN which is a single byte. The Emba version should use Boolean rather than Bool as the return type. It's a screw-up from top to bottom. Anyone might think that they just write this stuff and don't test it ......
  19. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    SETZ BL XOR EAX, EAX MOV AL,BL Don't you just need SETZ AL MOVZX EAX, AL Also, .NOFRAME is wrong here. You need the frame to preserve RBX. At least that's how I understand it.
  20. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    Has anybody looked at the equivalent for msvc, gcc, clang, etc?
  21. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    I submitted a QP report for InterlockedCompareExchange128 not restoring rbx
  22. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    To me it is much cleaner to comment at the top of the routine which register each parameter travels in, and then stick to registers. That allows you to see teg register usage directly rather than having an extra level of indirection.
  23. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    You are restoring volatile registers there. That's wrong. Most egregious is where you restore rax which has the return value. Ah, i read the bit where you say "the others do nothing". I guess the compiler knows they are volatile / used for param/return passing. I'd remove them all the same. You really must stop using parameter names in asm because it obfuscates the fact they they live in registers, and which ones.
  24. David Heffernan

    Revisiting TThreadedQueue and TMonitor

    Probably remove that +8. But I'm guessing there. I'd never write asm using variable names. You simply have to write the whole thing using registers to keep track of what it where.
×