-
Content Count
3710 -
Joined
-
Last visited
-
Days Won
185
Everything posted by David Heffernan
-
Boolean evaluation
David Heffernan replied to Ole Ekerhovd's topic in Algorithms, Data Structures and Class Design
It would have been trivial to solve if only you'd used the debugger. Make it your next mission to learn how to use the debugger. -
Boolean evaluation
David Heffernan replied to Ole Ekerhovd's topic in Algorithms, Data Structures and Class Design
It's simple. Why write if SomeBool = True then when you can write If SomeBool then It simply adds nothing. -
Boolean evaluation
David Heffernan replied to Ole Ekerhovd's topic in Algorithms, Data Structures and Class Design
Why is it so hard to reach the conclusion that aUser.Administrator is false? Instead of being helpless here, you can get help from us by providing a minimal reproduction. Easier still would be simply to debug your program. Have you done that? -
Boolean evaluation
David Heffernan replied to Ole Ekerhovd's topic in Algorithms, Data Structures and Class Design
Never compare to False or True. Instead write if someBool then Or if not someBool then That's not your problem though. Your problem is quite simple. It's the most obvious explanation. You are mistaken, in fact aUser.Administrator is false. It's that simple. -
Why is ShowMesssage blocking all visible forms?
David Heffernan replied to Mike Torrettinni's topic in VCL
Yeah, modal dialogs and popup are deeply invasive. Find a different way to let the user know. -
As discussed above the conditional code simply adds clutter for no benefit. The compiler has already handled the issue for you. Remove the conditional, and let the compiler ignore stdcall in x64. A second point is the use of the export directive. It is also always ignored (a hangover from 16 bit days). Again it should be removed. Therefore the best practise would be to write: procedure MyProc; stdcall; And that's it. Obviously you still need the exports list somewhere.
-
Minimising Mainform but leaving sub forms normal
David Heffernan replied to Ian Branch's topic in General Help
It depends on the window ownership (aka popup parent) relationships between your forms. What is that in your case? -
The ifdef is pointless and wasteless. On x64 stdcall is, like all calling conventions, ignored. So remove the ifdef and leave stdcall there for the platform that it has meaning.
-
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
This class can't be used without the compare type being specified. -
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
This seems bogus. Define "really core" please. -
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
You are advocating defining new classes in order to set a single field in the base class. If you can't see what is wrong with that I am surprised. I already said. -
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
OMG, take a poor idea, and make it much worse -
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Also a false goal. -
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
That's a false goal. Remove that goal from your life. Following it will be making your code worse. -
Is Class with 2 'nested' constructors bad design?
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
It works. But better to have one constructor that accepts an argument. Think of the time you need to decide at runtime which path to take. Then your way is hopeless. -
How should I organize cross platform code?
David Heffernan replied to Mike Torrettinni's topic in Cross-platform
Ugh, the code you write shouldn't need those ifdefs. That the entire point of you using the libraries provided by others, like Emba. They present a common interface to you. That's the entire point of cross platform coding. -
language updates in 10.4?
David Heffernan replied to David Schwartz's topic in RTL and Delphi Object Pascal
Spend some time looking at the development process and quality over in C# and .net land, and then see if you honestly can regard Emba's process and quality even remotely in the same ball park. -
It's not a choice between either generics, or polymorphism. You can use both.
-
Because that's the only way to make this work. Your expectations seem unrealistic. As I see it you face two choices: 1. Code it the way I said, and thus have your code work the way you want. 2. Code it your way, and have your code not work the way you want. I don't understand why you want to take option 2.
-
constructor constraint isn't going to be much use here, you can get rid of it. What you need is a virtual constructor on the base class, and virtual methods. And then obviously to override those methods on subclasses.
-
What is the best way LoadFromFile & Thread? (FMX)
David Heffernan replied to pieomy00's topic in FMX
We don't really know what your main goal is. Hard to give useful advice. -
What is the best way LoadFromFile & Thread? (FMX)
David Heffernan replied to pieomy00's topic in FMX
Define "best" please. Also, the try/finally seems a little pointless. -
Generics and Classes on Windows 2000 = OOM
David Heffernan replied to aehimself's topic in General Help
no -
language updates in 10.4?
David Heffernan replied to David Schwartz's topic in RTL and Delphi Object Pascal
The eternal optimist -
Generics and Classes on Windows 2000 = OOM
David Heffernan replied to aehimself's topic in General Help
Strange suggestions given that all symptoms point to memory leak in your code.