-
Content Count
3737 -
Joined
-
Last visited
-
Days Won
188
Everything posted by David Heffernan
-
What calling convention is the function? If it is register then that is a problem. Make sure it is stdcall. A websearch for pinvoke will tell you how to call this function.
-
Range checking in library code?
David Heffernan replied to Stefan Glienke's topic in Algorithms, Data Structures and Class Design
Conceptually a list class is the same as an array. For sure it has extra convenience functionality, but it is still a random access array. So my philosophy is that consistency is achieved by having lists match arrays. I'd have the range checks conditional on RANGECHECKS. Indeed that is how I do it in my personal collection library. -
IFileOperation recursion happens when set not to
David Heffernan replied to RTollison's topic in General Help
You have to enumerate all the files and copy them. Put these files into a double null terminated list. COM should not be initialised here. It needs to be initialised by the owner of the thread. -
What is the best way to split off a new project?
David Heffernan replied to Jud's topic in General Help
I have a unit with 53kloc (hangs head in shame) -
What is the best way to split off a new project?
David Heffernan replied to Jud's topic in General Help
This is a branch or a fork in your SCM system. If you aren't using SCM then that's your problem right there. Solve that problem first. -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Don't think so https://en.cppreference.com/w/cpp/language/enum -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
That's what scoped enums are meant for -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
This is exactly the issue that scoped enums solves already. -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
That's XE7. It seems to me to be folly to design your code based on an IDE tooling issue, and especially one which is soon to be resolved. Further, the issue at stake here, as always when coding, is far less about the experience when writing code, as the experience when reading code. It's not worth it to reduce the readability of your code to give a minor easing to your experience when entering the code. -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Following on from my comment about complexity, I'm wondering what's wrong with this: You don't need to remember anything. Why are you seeking complexity here? You seem to be trying to solve a problem that simply does not exist. -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Why is that harder than remembering something else, as you seem to want to do? Why is complexity so compelling? -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
You'd be far better off using scoped enumeration. It forces you to fully qualify the enumeration. Instead of deciding what the solution is beforehand, you are better off understanding the options offered by the language and working with the language, not swimming against the tide. -
Initialization of returned managed types
David Heffernan replied to pyscripter's topic in RTL and Delphi Object Pascal
It all went downhill when Borland decided that function return values were actually var parameters. Which means that in the case of managed types they get initialized by the caller. A function return value really should have pass by value callee to caller semantics. -
Organizing enums
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
What problem are you trying to solve? What's wrong with vHTMLReportType := htTemplate; -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
You missed step 1. Step 1: identify the bottleneck. It's a common mistake. -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
All this incredible noise, and all Mike needs is to simply time his own program...... It's really so simple..... -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
I don't really buy what Kas is saying above. Just time your actual program is usage scenarios that you care about. After all, why would care about the performance of code that you never run? You only care about the code that you do run, or your users run. -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Because timing a for loop doing 1,000,000,000 iterations of nothing meaningful is nothing more than a low grade PRNG. Put something realistic inside the loop, and then time it. -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
It isn't. Hmm ..... -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Well, it's reasonable to wonder about that, and Stefan talked about that. But you actually spent a lot of time talking not about the codegen, but about performance. And the key point is that there is no performance difference for the two versions of the code that you presented, once you put the code in a context where it actually does something. After all, the code you showed doesn't initialise any variables, and just performs the exact same two comparisons on each iteration of the loop. Here's a question for you, why don't you compare the run time of your code, with code where your for loop is removed? I bet it will be faster with the for loop removed. And the code does the same thing with or without the for loop. Obviously that's silly because the for loop is meant to represent some real world code. But it's only meaningful in the context of actual production code. I've said it many times, but when you put your two variants into your real world program, you won't be able to tell them apart from the perspective of performance. -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Can I ask again why you are timing something that has no relevance to the performance of the code that you care about? Once you time these variants in a real program, you will find that you won't be able to detect any difference in runtime. And then you will draw the conclusion that the best way to write the code is in a manner which avoids duplication of code, and which makes it easy to maintain. You'll likely also decide that there is no real gain in explicit inlining of the function here, and will stop doing that. -
Oz-SGL, a new generic collections library based on the idea of C++ STL
David Heffernan replied to Edwin Yip's topic in Algorithms, Data Structures and Class Design
Records can be managed types -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
That's not the conclusion of this topic. -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
Why are you doing this? Have you timed your actual program yet? Do the two options perform measurably differently? Is that code even a bottleneck? -
Simple inlined function question
David Heffernan replied to Mike Torrettinni's topic in Algorithms, Data Structures and Class Design
This test seems pointless because the two strings are always empty. You never read the strings from a collection. You never compare two strings. When you put this code into a realistic setting you'll likely find that it makes no difference to performance which versions you use. The smells of premature optimisation. And that results in hard to maintain code.