Jacek Laskowski

15 hours ago, stijnsanders said:

If you're interested in another alternative, I've started from the root document to make a pure-Delphi version under a permissive license: https://github.com/stijnsanders/tools/blob/master/crypto/aes.pas

I also did HMAC and PKDF2 here

Maybe it is worthwhile to move the 'crypto' library to a new, separate repository?

In a common, large repo it is difficult for anyone to find it

@Dmitry Arefiev

  Maybe now you can reply to this issue? I still fight with it.

History window:

Old MMX 14:

$4000? Really?

Imho Indy is a better option because of its popularity and versatility.

And I say this even though I use mORMot myself.

But of course it would be good to leave support for newer versions based on System.Net.HttpClient.
This means that it is best to pack the REST client into a new class and change its implementation as needed: Indy or System.Net.HttpClient

Maybe it is worth to surround the scope check by conditional directives?

By default, the scope check would be enabled in debug and release, and for demanding users it would be possible to achieve maximum performance at the expense of a slightly more difficult configuration.

I use the latest version of MMX and the problem described above still occurs sometimes. Today I noticed an additional symptom. I have two methods in class, located next to each other, the same names, but the first one is generic and inactive (marked as a comment). After editing the second one and approving both were moved to the beginning of the class:

On 9/21/2020 at 10:36 PM, Remy Lebeau said:

Correct.  Andreas has already gone on record stating that he no longer has a license to paid versions of RADStudio and so will not be able to update IDEFixPack for new IDE versions without their Community Editions.  And Embarcadero has already gone on record stating that releasing a 10.4 Community Edition has been delayed, with no ETA stated as of yet.

Sarina DuPont, comment from 5 months ago:

"10.3.3 versions of Delphi and C++ Builder Community Edition remain available for download. 10.3.3 was an excellent release and Community Edition users can perfectly well continue to work with that release. 

@Kas Ob.

Maybe you should put on a new thread with your proposal, this one concerns my proposal, ok?

40 minutes ago, Uwe Raabe said:

The configuration may lead to a big ball of mud quickly. Just your suggestion 

assumes that anyone uses lower case prefixes in the first place. I have seen some significant number of coding style guides that prefer the capital letter A.

 

While I can see the benefit for your personal case, I expect difficulties to make it suitable for the general audience.

Ok, I actually assumed that everyone uses lower case letters as prefixes
But let's think about the cases.
Let's assume that we want to use the letter 'a' as a prefix, in which case all the possibilities of the end result are:

name -> aname
Name -> aName
Array -> aArray
array -> aarray ??

When the beginning of the name already contains a small 'a' (in case of re-editing), it is enough to check if the beginning is consistent with 'a', only the last example introduces an ambiguity, because 'array' starts with 'a' and it is not known if it is a 'rray' with an added prefix or 'array' without a prefix.
In this case, I would leave 'array' unchanged (which works well for editing the aarray parameter as well).

The case with the prefix written in capital letters 'A':

name -> Aname
Name -> AName
Array -> AArray ??
array -> Aarray

In this case, the third case (Array) is ambiguous. I would leave it unchanged, similarly as above.

These conditions do not seem very complicated, have I overlooked something?

9 minutes ago, Stano said:

The Hungarian notation refers to prefixes identifying the type of variable, this is something else.

OK.

If I use the prefix to avoid collisions with variables, then only "A". So how Lars Fosdal.

As I wrote in the first post this functionality would be optional and configurable.

9 minutes ago, Stano said:

Hungarian notation is said to no longer be used in OOP.

The Hungarian notation refers to prefixes identifying the type of variable, this is something else.

3 minutes ago, Lars Fosdal said:

All my method arguments start with a - regardless of if they are const, var or out.

In this case you would have all 3 kinds of prefixes marked as 'a'.

I have a proposal for a new functionality for MMX. It is a simple change, and for me, and I hope other users too, can be very useful.

I use prefixes in the names of method parameters, I personally prefer the letters a, o and v for const, out and var parameters, respectively:

procedure Somethinghing(const aInput : Integer; out oOutput : string; var vOther : string);

Thanks to this, inside the body of the method, I know which parameter has which features and whether I can (var) or should (out) change it. This greatly improves code readability and error avoidance. Of course I write about myself 😉

I suggest adding a function to MMX that could be called "Forcing a parameter name prefix". Of course, the prefix (a, c and o) themselves could be set in the MMX configuration (just like the prefix for object fields).

Additionally, in the configuration I would also give a checkbox "Force parameter name prefix", which would be the default value when editing the method (ctrl+E) and which could be incidentally unchecked or checked as in the picture:

Using the "force prefix" option would work in such a way that if the parameter has some prefix (lowercase letters in front, before uppercase) they would be replaced, e.g. xParam -> aParam, xyParam -> aParam, and if the parameter has no prefix then it would be added, Param -> aParam

Does this idea seem good to you and you would take it up?

https://www.thedelphigeek.com/2019/04/fastmm4-large-memory.html

Inline was added in D2005:

https://edn.embarcadero.com/article/33050

18 minutes ago, Dmitry Arefiev said:

When FDQuery's use ConnectionName, then single temporary TFDConnection will be created transparently and used by all FDQuery's, etc

And unfortunately this is a certain inconsistency, because when I create FDConnection and assign it ConnectionDefName, a physical, new connection is taken from the pool.

Why doesn't he do it with Query if he gets a new, automatically created FDConnection in the same way? Couldn't this new FDConnection also get a new, unique connection from the pool?

I downloaded GExperts sources and tried to build... without success, I get error on prebuild step:

PreBuildEvent:
  call ..\..\images\_CreateGXIconsRc.cmd&&call ..\..\buildtools\prebuild.cmd "d
  :\Work\GExperts\Projects\DelphiXx103\GExpertsRS103.dproj"&&call ..\..\buildto
  ols\movedll.cmd "d:\Work\GExperts\Binaries\GExpertsRS103.dll"
  generating GXIcons.rc in d:\Work\GExperts\Images
  Borland Resource Compiler  Version 5.40
  Copyright (c) 1990, 1999 Inprise Corporation.  All rights reserved.
  Nazwa pliku jest powtórzona, albo nie można odnaleźć pliku.
C:\Program Files (x86)\Embarcadero\Studio\20.0\bin\CodeGear.Common.Targets(402,
5): error MSB3073: The command "call ..\..\images\_CreateGXIconsRc.cmd&&call ..
\..\buildtools\prebuild.cmd "d:\Work\GExperts\Projects\DelphiXx103\GExpertsRS10
3.dproj"&&call ..\..\buildtools\movedll.cmd "d:\Work\GExperts\Binaries\GExperts
RS103.dll"" exited with code 1. [d:\Work\GExperts\Projects\DelphiXx103\GExperts
RS103.dproj]
Done Building Project "d:\Work\GExperts\Projects\DelphiXx103\GExpertsRS103.dpro
j" (rebuild target(s)) -- FAILED.

Error message "Nazwa pliku jest powtórzona, albo nie można odnaleźć pliku." after translate to english means: "The file name is duplicated or the file cannot be found.'"

But which file?

Ok, I forgot   FDManager.Active := True; at the end of the RegisterConnectionDefinition() method, but it doesn't change anything, after adding the errors are the same.

And as for the connection... I don't use the same connection, I use a pool that is managed by FireDAC, so I assume that for every query it gives a new connection, isn't that how it should work?

from documentatio9n:

"The ConnectionName property value must be specified before Prepare call. If it matches the name of one of connection definitions, then FireDAC will transparently create connection object and link the dataset with it. "

21 minutes ago, Stefan Glienke said:

would been kinda cool to provide some more information before asking to vote for something you have to gather information about on your own. 

exactly!

Hi,

I found a serious FireDAC bug, I wrote a minimal sample program to reveal it, you need a Firebird server and any database to run. Maybe there is also a problem with other servers, I did not check.

The problem occurs when you do not explicitly assign the FDConnection control to the FDQuery, but use the registered Connection Definition Name and assign it by Query.ConnectionName and occurs when Connection Definition Name is used more than once at a time (in thread).

The result is a mass of random errors, each time you run it, there are different errors, in a different place of FireDAC code.

Source of example, console app:

program FDPoolingBug;

uses
  System.Threading,
  System.Classes,
  Winapi.Windows,

  FireDAC.Phys.IBWrapper,
  FireDAC.Phys,
  FireDAC.Phys.FBDef,
  FireDAC.Stan.Intf,
  FireDAC.Stan.Def,
  FireDAC.DApt,
  FireDAC.Phys.FB,
  FireDAC.Stan.Pool,
  FireDAC.Stan.Async,
  FireDAC.Comp.Client,
  System.SysUtils;

{$APPTYPE CONSOLE}

{$R *.res}


const
  CONN_DEF_NAME = 'CONNECTION_TO_DB';

var
  bEnd : Boolean = False;

procedure RegisterConnectionDefinition();
var
  oConDef: IFDStanConnectionDef;
  oPars: TFDPhysFBConnectionDefParams;
begin
  if FDManager.ConnectionDefs.FindConnectionDef(CONN_DEF_NAME) = nil then
  begin
    oConDef := FDManager.ConnectionDefs.AddConnectionDef;
    oConDef.Name := CONN_DEF_NAME;
    oPars := TFDPhysFBConnectionDefParams(oConDef.Params);
    oPars.DriverID := 'FB';
    oPars.Server := '192.168.1.10';
    oPars.Database := 'Some_FB_Database.FDB';
    oPars.Port := 3060;
    oPars.Pooled := True;
    oPars.PoolMaximumItems := 100;
    oPars.PoolCleanupTimeout := 30000;
    oPars.PoolExpireTimeout := 90000;
    oPars.UserName := 'sysdba';
    oPars.Password := 'masterkey';
    oPars.SQLDialect := 3;
    oPars.Protocol := ipTCPIP;
    oPars.CharacterSet := TIBCharacterSet.csUTF8;
    oConDef.Apply;
  end
end;

procedure QueryWithAutoConnection(); //This method works incorrectly
var
  lCounter: Integer;
  lId: Integer;
  lQuery: TFDQuery;
begin
  lId := GetCurrentThreadId() mod 99;
  Writeln('start: ', lId);
  try
    lQuery := TFDQuery.Create(nil);
    lQuery.ConnectionName := CONN_DEF_NAME;

    lQuery.SQL.Text := 'select * from rdb$database';
    lCounter := 0;
    repeat
      lQuery.Open;
      lQuery.Close;
      Inc(lCounter);
      if lCounter = 1000 then
      begin
        lCounter := 0;
        Writeln(lId);
      end;
    until bEnd;
  except
    On E : Exception do
    begin
      writeln(Format('id: %d, Exception: %s, Desc: %s', [lId, E.ClassName, E.Message]));
      Writeln;
    end;
  end;
end;

procedure QueryWithDedicatedConnection(); // This method works correctly 
var
  lConn: TFDConnection;
  lCounter: Integer;
  lId: Integer;
  lQuery: TFDQuery;
begin
  lId := GetCurrentThreadId() mod 99;
  Writeln('start: ', lId);
  try
    lConn := TFDConnection.Create(nil);
    lConn.ConnectionDefName := CONN_DEF_NAME;
    lQuery := TFDQuery.Create(nil);
    lQuery.Connection := lConn;

    lQuery.SQL.Text := 'select * from rdb$database';
    lCounter := 0;
    repeat
      lQuery.Open;
      lQuery.Close;
      Inc(lCounter);
      if lCounter = 1000 then
      begin
        lCounter := 0;
        Writeln(lId);
      end;
    until bEnd;
  except
    On E : Exception do
    begin
      writeln(Format('id: %d, Exception: %s, Desc: %s', [lId, E.ClassName, E.Message]));
      Writeln;
    end;
  end;
end;

procedure RunOne();
var
  aTask: ITask;
begin
  aTask := TTask.Create(QueryWithAutoConnection);
  aTask.Start;
  TTask.WaitForAll([aTask]);
end;

procedure RunParallel(lThreadCount : Integer);
var
  aTasks: TArray<ITask>;
  i: Integer;
begin
  SetLength(aTasks, lThreadCount);
  for i := 0 to Pred(lThreadCount) do
  begin
    aTasks[i] := TTask.Create(QueryWithAutoConnection);
    Sleep(10);
    aTasks[i].Start;
  end;
  TTask.WaitForAll(aTasks);
end;

begin
  try
    RegisterConnectionDefinition();
    //RunOne;
    RunParallel(3);
    Readln;
  except
    on E: Exception do
      Writeln(E.ClassName, ': ', E.Message);
  end;
end.

Can someone check it in Delphi 10.4.1?

I use Delphi 10.3.

What is SAST?

Please ask here:

https://groups.google.com/g/firebird-support

15 minutes ago, Kas Ob. said:

3) Ditch TNetHTTPClient and look for alternative (there is dozens), most likely will find higher quality and better functionality. 

NetHTTPClient has one huge advantage... When working with SSL/TLS it uses the system api and you don't have to fight with openssl, certificates etc.

In your class constructor, you should assign these events, something like:

constructor TmyNetHTTPClient.Create()

begin

  inherited Create;

  OnReceiveData := ReceiveData;

  OnRequestComplewted := RequestCompleted;

end;

Try to use OutputDebugString() function from WinAPI and this tool for viewing output:

https://docs.microsoft.com/en-us/sysinternals/downloads/debugview