Tommi Prami

I'd do it some other way, ad begin end and comment in between or something that it is more clear. (Thee was better version by earlier, so skip this 🙂 )

That seems to be correct, thousands separators are not accepted, so have to first handle them self.

with MainForm, ButtonCancel do ... with MainForm do with ButtonCancel do ... Nested with clauses are pure evil to refactor out. If it is complex code and there are common properties (Like Caption in VCL on above) how to decode which is which. Made feature request of this one way way back. Hope they make refactorer that would cast the first stone, so can manually refactor rest. : https://quality.embarcadero.com/browse/RSP-18953

StrToDate('2021/12/31'); Using StrToDate() etc with Date/Time literal in code, that most likely will fail in other locals than yours, Also the EncodeDate etc routines giving numbers is better IMHO.

try .. except end; eating all exceptions without commenting why exactly, and why it isn't or can't be something more specific.

IntToStr(LDataSet.AsInteger); Could use AsString directly.

try ... finally end; Empty finally blocks, maybe .free call is missing or after refactoring it has become obsolete but left behind. Not sure can the compiler optimize that out, that seems to me unneeded code that should be removed or fixed other way.

if A > B then; ... if A > B then A := B else; Semicolon right after the then or else is legal syntax, and can be used rightly, but I think those are possible point of errors and not easy to spot

Has to be handled anyways. -Tee-

When Thousand separators come into play, it starts to get almost impossible, (At least in here). 1,006.66 or 1 006,66 or 1 006.66 etc... And if sometimes there are no decimals. How to fix US version without decimals 1,006 and Finnish ones with them 6,66. As far as I know there can't be universal routine to rule them all. US I think thousand separator is Comma, here it is decimal separator. THis is one of the places there would have been nice to have global standard, and only one 🙂 -Tee-

Seems that "Parnassus" plugins are not available for it on GetIt, Bookmarks make IDE so much better, would love to have it on home computer also, but I manage, if David Millington happens to read this, try to get those in GetIt for Community edition also. -Tee-

This happens sometimes

Has anyone done any benchmarking lately on JSON libs? Ones I have seen are bit old I think. (I am not needing one right now, but would be good for the community if someone woulöd do something like that) .Tee.

Please Update Ticket: https://quality.embarcadero.com/browse/RSP-34302 And/Or make new one, if you can pinpoint the exact cause of the slowdown. (If it is actually true performance regression between those Delphi versions) -tee-

I bet that using JPEGImg.Scale:=js* Is really fast but not sure how good visual quality will it have. Bitmap32 library has good quality Resamplers but for sure it'll take way longer than that. -Tee-

Same person.

I know it is quite simple thing to do, but still would preferably use some already tested implementation. Does any Delphi Lib have such a routine? -Tee-

Using CopyFileEx with quick and dirty simplem,entation, fixed my problem, more than less.. I bet dzlib one is not as crude as mine, have to check that out... -Tee-

Nice... Have to check out that... -Tee-

That raise : if not DoCopy(SourceFileName, DestFileName, Overwrite) then raise EInOutError.Create(SysErrorMessage(GetLastError));

What is the point of this Exception? And how to handle it 🙂 IT sems that Actually file is not copied 😄 This is so weird 😄 -Tee-

I need to have one in the Command Line APP. Most likely it'll be OK for me to use TFile.Copy, as this small utility will run in one single machine. But had got interesting errors while testing it just now over Slow 4G connection and VPN. Did not take screenshots but one was something like "Operation failed successfully" or something similar weirdness. And network path disappeared underneath and so on. Now that Schools are out my Internet bandwidth in here in rural areas of Finland plummeted totally. All house wifes watching PiornHUB and kids YouTube, I think.

To make results easier to read, could the numbers have thousand separators? At least for me it is hard to compare two numbers if they aren't next to each other: 23432422 .... .... .... .... .... .... ... .... ... 4343241 Are they even at same ballpark. Some people have very good eye on are things on same line, for me it is almost impossible 🙂 -Tee-

Very glad to everyone that brought this in my attention. Did not know all this. Now just have to remember this. -Tee-

Is anyone using it or planning on migration? Don't know personally nothing about those (basically), but if anyone has info about that project and using would be nice to know. "Tools" we use now on our internal Infra are: SVN Jenkins Mantis And most likely result would be Azure DevOps GIT (Possibly Jenkins if makes sense, but maybe not) -Tee-