OverbyteIcsWebSocketCli: Adjustment suggestion

[e.c 0]

Good morning !

 

We had a little trouble debugging this way. Here is a suggested adjustment, if possible.

 

At OverbyteIcsWebSocketCli.pas, line 954:
            ... 
            if State in [wsfsCompleted, wsfsNotComplete] then begin
                j := 0;
                for i := 0 to DataBytesInBuf-1 do begin
                  { PData^ := PData^ xor Mask[j]; // Original
                  } {$R-} PData^ := PData^ xor Mask[j]; {$R+} // Suggestion
                    Inc(j);
                    if j > 3 then
                        j := 0;
                end;
            end;
            ...

Thank you for your attention.

[Angus Robertson 526]

Thanks, I'll look at this when I get back to ICS next week. 

 

Note, there is an ICS forum for future support, but you don't need to repost this topic.

 

Angus

 

[JiyaHana 0]

if State in [wsfsCompleted, wsfsNotComplete] then begin
    j := 0;
    for i := 0 to DataBytesInBuf - 1 do begin
        {$R-}
        PData^ := PData^ xor Mask[j];
        {$R+}
        Inc(j);
        if j > 3 then
            j := 0;
    end;
end;

Try this.

[Angus Robertson 526]

Quote

Try this. 

Your code looks the same as the original suggestion, which was added to the version in SVN last month.  There are other fixes to this unit pending. 

 

Seems to be quite an interest in the new ICS websocket components. 

 

Angus