Jump to content
PeterPanettone

Display GExperts source version and date on Splash Screen?

Recommended Posts

Posted (edited)

The IDE Splash screen always shows the same GExperts version number:

 

image.thumb.png.f3ee49f93e800a2033491c6ebfa76065.png

 

Wouldn't it be helpful to show the current source version, too? (Currently: [r4257]), and the date of the source snapshot.

Edited by PeterPanettone

Share this post


Link to post

If I remember correctly (can't check right now) the build number is supposed to correspond to the revision number of svn. The screenshot doesn't look like that is working though.

Share this post


Link to post
Posted (edited)
38 minutes ago, dummzeuch said:

doesn't look like that is working though

Yes, you are right; this seems to be a bug. The Splash Screen shows:

 

GExperts
Version 1.3.24 build 0

 

Downloaded from:

 

image.thumb.png.884399205c3b8539a0b7e545955d76a6.png

Edited by PeterPanettone

Share this post


Link to post
8 hours ago, PeterPanettone said:

Yes, you are right; this seems to be a bug. The Splash Screen shows:

 

GExperts
Version 1.3.24 build 0

 

Downloaded from:

 

image.thumb.png.884399205c3b8539a0b7e545955d76a6.png

You mentioned in a different thread that you downloaded a napshot. There is no subversion revsion number available in that case, so you get the build number 0. On my computer with freshly checked out sources to a new folder, I get build 4256, which matches the svn revision number.

 

Which reminds me of a warning in yet another different thread not to use that number because it is some subversion specific thing and doesn't exist in other SCMs.

Share this post


Link to post

The build number is generated by the following entry in GExperts_version.ini and the call to dzprepbuild in the prebuild.cmd which is called in the pre-build event of the project:

 

Build=redirect:..\..\SVN_Version.ini,SVN,HighestVersion

 

SVN_Version.ini is a template updated by a call to the subwcrev subversion command in prebuild.cmd.

 

So, in a subversion working copy the process is automatic.

Share this post


Link to post
Posted (edited)
2 hours ago, dummzeuch said:

I get build 4256, which matches the svn revision number

What has the SVN revision number to do with the source revision number? If someone downloads the source not with SVN but directly from the snapshot, as indicated in the above screenshot, then no SVN revision number can be retrieved. So, you should output the revision number in the Splash Screen by retrieving it directly from the source (and not from SVN).

Edited by PeterPanettone

Share this post


Link to post

So you should include an explicit warning: "WARNING: If you download the snapshot and compile the DLL from that source then no revision number will be shown in the Splash Screen!"

 

Maybe you could also include a SKULL ICON ☠️ in the warning.

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×