Fr0sT.Brutal 900 Posted April 1, 2021 Ensures x64-safe typecasts in 6 units of old demos. Note: Francois' name in unit headers got damaged by Git patch generator though the commit didn't contain that change. Must be reverted manually 0001-Samples-change-unsafe-Integer-Pointer-typecasts-to-W.patch Share this post Link to post
Angus Robertson 574 Posted April 1, 2021 Your patches don't work on my working copy, I look for changes manually. The samples were never designed or tested to build on Win64, only the components, although we do test the actively supported samples periodically. Angus Share this post Link to post
david_navigator 12 Posted April 1, 2021 20 minutes ago, Angus Robertson said: Your patches don't work on my working copy, I look for changes manually. The samples were never designed or tested to build on Win64, only the components, although we do test the actively supported samples periodically. Angus It's not just 64 bit - smtpQuit : PostMessage(Form1.Handle, WM_REMOVEOBJ, Integer(Sender), 0); + smtpQuit : PostMessage(Form1.Handle, WM_REMOVEOBJ, WPARAM(Sender), 0); as discussed here, Share this post Link to post
Fr0sT.Brutal 900 Posted April 1, 2021 1 hour ago, Angus Robertson said: Your patches don't work on my working copy, I look for changes manually. The samples were never designed or tested to build on Win64, only the components, although we do test the actively supported samples periodically. Angus That's weird. I based them on V8.66 - Part 10. Probably that encoding issue of Francois' name is the reason. Share this post Link to post
Angus Robertson 574 Posted April 7, 2021 Your Win64 fixes are now in SVN thanks, with a couple more that you missed because they were LongInt. Fortunately most PostMessages already casted pointers correctly, just these older samples. Angus 1 Share this post Link to post