Typo in comment (not a big deal)

[Kyle_Katarn31 0]

In OverbyteICSHttpProt.pas:3479

 

        { pending, check https for SSL prpoxy, maybe socks for socks proxy }

 

proxy, not prpoxy

[Angus Robertson 574]

Thanks, just tidying up a few units, will be done today - not the SSL support...

 

Angus

[Kyle_Katarn31 0]

(thanks for the clean up and fix of glitches)

So you confirm that current proxy client implementation is for HTTP only, not HTTPS ?

Edited May 24, 2021 by Kyle_Katarn31

[Angus Robertson 574]

That comment only relates to setting the various component proxy properties using a single URL, for convenience.  

 

The THttpCli component always connects to forward web proxies without HTTPS, but will make HTTPS requests through those proxies using the CONNECT method.  Not sure if forward web proxies exist that use HTTPS. 

 

Angus

 

[Kyle_Katarn31 0]

OK thanks !

One of my users is expecting issues when using my software behind squid for HTTPS. When using http, it works fine (and same with https with proxy disabled). Any clue on possible issue related to ICS ? Or maybe specific squid configuration to check ?

 

Thanks for your excellent work.

 

More here : 

 

Edited May 24, 2021 by Kyle_Katarn31

[Angus Robertson 574]

Sorry, never looked at Squid.  But ICS will not use TLS to a proxy irrespective of the port specified  You really need some logging to see what is happening.

 

Angus

 

[Kyle_Katarn31 0]

OK thanks

[Kyle_Katarn31 0]

Btw, I also see this comment (line 1178):

 

{ ServerAuth and ProxyAuth properties are still experimental. They are likely
  to change in the future. If you use them now, be prepared to update your
  code later }

 

Is it still relevant ?

[Angus Robertson 574]

That comment is ancient, written by another developer, not really looked at that code.

 

Angus

 

[Kyle_Katarn31 0]

2 hours ago, Angus Robertson said:

That comment is ancient, written by another developer, not really looked at that code.

 

Angus

 

OK... maybe worth being removed...