Patches for ICS

[Vasilich 0]

Hello.

First i would like to thank all the authors of ICS for its creation and support.

We use it in our working process, and made some patches (for HTTP part), that we see as corrections to existing implementation. On the webpage of ICS i haven't found a way to send patches, and Github has very outdated version of ICS, so i decided to ask here:

How can i send patches/do a pull request/whatever else way to correct  behaviour of some things in ICS for it to be available to public? If the patches will be accepted, then we can use ICS packets from GetIt to install and update ICS in Delphi.

I can generate diffs and explain every change we made - just tell me the preferred way of doing this.

 

Thanks in advance,

[Angus Robertson 574]

ICS has never been available from GitHub, someone must have stolen it and reposted it there without permission. 

 

We use a private SVN server, https://svn.overbyte.be/svn/ use the ICS branch. 

 

But I prefer to add patches using WinMerge comparing complete old and new units (no diffs), so please email complete units with your new code commented so I know why it is there.  My email is in various ICS units and the readme.

 

I suggest you look at the OverbyteIcsHttpProt,pas unit in SVN today, there were a many changes yesterday from another contributor. 

 

Angus

 

[FPiette 383]

28 minutes ago, Angus Robertson said:

ICS has never been available from GitHub, someone must have stolen it and reposted it there without permission. 

Don't worry, I have done that GitHub repository long time ago. It is completely outdated.

 

[Vasilich 0]

3 hours ago, Angus Robertson said:

please email complete units with your new code commented so I know why it is there

Sent file via forum "message" function, as it is a bit troublesome here to get to private email account from work. If you insist on using email - let me know, please, and i can do it tonight.