Attila Kovacs

good job! coupe of things: D2D1_DRAW_TEXT_OPTIONS_ENABLE_COLOR_FONT is first introduced in Delphi 20.0, maybe you should declare it somewhere with a conditional TOSVersion.Build returns 0 on my system, reporting wrongly that SVG is not supported o.O functions: -SetId() -CreateChild() -IsAttributeSpecified() -RemoveAttribute() -SetAttributeValue() *all -GetAttributeValue() *all? -GetAttributeValueLength() -FindElementById() -CreatePaint() should have LPCWSTR parameters instead of LPWSTR. (just to be pedantic)

btw. in the header and also on the screenshot from Mahdi the first parameters are PCWSTR (LPCWSTR) (const) and not always PWSTR (LPWSTR). this however makes no difference, at least at the moment, as they are defined the same in delphi

opacity : single := 0.5; Element.SetAttributeValue('opacity', D2D1_SVG_ATTRIBUTE_POD_TYPE_FLOAT, @opacity, SizeOf(opacity)); where element = 'svg' if this was the question

@pyscripter yup, was just playing around, it's also RGBA so the original 1, 0, 0, 0 did also not make much sense, mentioned that already earlier

@Kas Ob. is right. With his order this works too: Element.SetAttributeValue('fill', D2D1_SVG_ATTRIBUTE_STRING_TYPE_SVG, '#FF0000');

@Kas Ob. your version AV's here, I get the recoloring 😄 what now hm, sorry, it works, so declare in reverse order?

@pyscripter d2missing again without the reformatting, sorry 😉 D2DMissing.7z btw. he is using IDA btw2. RecolorSubtree(Root, D2D1ColorF(1, 0, 0, 0)); should be the other way, 0,0,0,1, rgba

ofc some of the const's I had to declare as it did not compile at the beginning, Berlin U2. svg.7z

yippiii, it works. nice one @Mahdi Safsafi

As I first mentioned the in the AV reading address 0x00000001, the "1" is the parameter D2D1_SVG_ATTRIBUTE_POD_TYPE_COLOR. Change it to D2D1_SVG_ATTRIBUTE_POD_TYPE_FILL_MODE and you will get AV reading address 0x00000002. So I thought that the wrong "SetAttributeValue" is called, so I changed the order of the "SetAttributeValue"'s => swapped the last two. But as I can't see any changes in the image and @Mahdi Safsafi showed in IDA that this is a completely different call, I'm not sure what is going on. But it's a good start for you to sort it out.

looks like I'm being ignored here. change the order of the last 2 SetAttributeValue()'s in the interface, no AV but I can't see any changes, maybe you would know why and see if it helps.

why don't you debug into the dll? "read of address 0x000000001" where "0x000000001" is D2D1_SVG_ATTRIBUTE_POD_TYPE_COLOR so just my 2 cent's the overloads are mixed up

The first time I saw your idea I did not see the benefits but after adding some useful information to the form it could be a great extension though. However, I'm not the OTA guy, so my version is using heavily the IDE itself, but the most could be achieved through the official way. (Assumed you will get the plugin API sources for Parnassus, which is not anymore available since emba purchased it....) or a bit more info:

yes, less, and slower, the rest is the same codegen -> less asm, slower exec, how's that? OoOE? Aligning?

by the way, if you look at the last code pasted by me, if you remove if len = 0 then exit(S); at the beginning, it's the same codegen and will be ~4% slower. Of course testing with non-empty input. Early triggering of OoOE?