Extreme slow-down in Windows FMX app UI since upgrading to 12.1

[Cristian Peța 122]

Using arrRect.SetBounds() you avoid a call to AlignObjects because TControl.SetBounds is checking some things before a call to AlignObjects

Avoid setting TPosition.X

Edited June 25 by Cristian Peța

[domus 2]

1 minute ago, Cristian Peța said:

Avoid setting TPosition.X

No kidding!  

[Patrick PREMARTIN 150]

4 hours ago, Cristian Peța said:

Using arrRect.SetBounds() you avoid a call to AlignObjects because TControl.SetBounds is checking some things before a call to AlignObjects

Avoid setting TPosition.X

Thanks @Cristian Peța

I've updated my sample project on https://embt.atlassian.net/servicedesk/customer/portal/1/RSS-3711

Hope they found a way to optimize this for 13.

[Cristian Peța 122]

Just wanted to try a fix in FMX.Forms and I found it already there but commented 🤔.

First two lines will exit and AlignObjects() will not be called if used Form.BeginUpdate. The Realign will be done anyway after Form.EndUpdate.

procedure TCustomForm.Realign;
begin
//  if FDisableAlign or (FUpdating > 0) then
//    Exit;
... more code
  if FCanvas <> nil then
  begin
    AlignObjects(Self, Padding, FCanvas.Width, FCanvas.Height, FLastWidth, FLastHeight, FDisableAlign);
    RecalcControlsUpdateRect;
    InvalidateRect(ClientRect);
  end;
end;

 

[domus 2]

Now, that's odd. As if someone forgot to uncomment before release...

[Cristian Peța 122]

I updated the report https://embt.atlassian.net/servicedesk/customer/portal/1/RSS-3711

[Lajos Juhász 325]

Maybe it is commented out to fix some strange issue/bug.  In that case the developer that has commented out the code should include the report number in the comment to document the change in behavior. 

 

[Patrick PREMARTIN 150]

40 minutes ago, Lajos Juhász said:

Maybe it is commented out to fix some strange issue/bug.  In that case the developer that has commented out the code should include the report number in the comment to document the change in behavior. 

 

It's probably done on the commit comment with an internal ticket number. No reason to put it in the source file on the comment visible by the public (= us).

Edited June 27 by Patrick PREMARTIN

[Lajos Juhász 325]

37 minutes ago, Patrick PREMARTIN said:

It's probably done on the commit comment with an internal ticket number. No reason to put it in the source file on the comment visible by the public (= us).

 

Most probably yes. It would be easier if we could get that information. I do hate when on codebase I am working on changes like this does not have a comment with a proper description or ticket number. Searching in repository for the specific change can be time consuming.