Found the cause of the AV on exiting the Delphi IDE

[dummzeuch 1506]

There was a bug in the (yet unreleased) GExperts code that caused an access violation every time the Delphi IDE was closed. I have just found it, but boy was that difficult!

I knew the problem existed in the current source code and by trial and error I found a source code revision that did not yet have it: #2415. So I compared those revisions and step by step narrowed it down to the changes in the unit GX_IdeFormChangeManager in revision #2433 which was a fix for a redrawing bug in the Delphi 10.2 Search Path dialog.

 

So I removed the code I had added ...

 

https://blog.dummzeuch.de/2018/11/24/found-the-cause-of-the-av-on-exiting-the-delphi-ide/

[Kryvich 165]

Perhaps it makes sense to put the code of form detection into a separate unit (if possible)? Then you will not have to add a new dependency between the old units. 

[dummzeuch 1506]

4 minutes ago, Kryvich said:

Perhaps it makes sense to put the code of form detection into a separate unit (if possible)? Then you will not have to add a new dependency between the old units. 

That's exactly what I did (50 minutes ago):

 

https://sourceforge.net/p/gexperts/code/2451/

[Fritzew 51]

Works well now, compiled for XE7, Tokio and Rio

[KHJ 8]

I have installed 10.2 Pro and 10.3 Pro

The current build process with __build.cmd is not working for me.

...

Drücken Sie eine beliebige Taste . . .

Das System kann den angegebenen Pfad nicht finden.
Der Befehl "msbuild" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
done building GExpertsRS102.dproj
Drücken Sie eine beliebige Taste . . .
DelphiPath: "="
*** Error: Directory "=" does not exist. ***
Drücken Sie eine beliebige Taste . . .
Das System kann den angegebenen Pfad nicht finden.
Microsoft (R)-Buildmodul, Version 4.7.3190.0
[Microsoft .NET Framework, Version 4.0.30319.42000]
Copyright (C) Microsoft Corporation. Alle Rechte vorbehalten.

Der Buildvorgang wurde am 25.11.2018 12:26:45 gestartet.
Projekt "E:\Benutzer\KHJL\Delphi\Libs\OpenSource\SourceForge\Gexperts\Projects\DelphiXx103\GExpertsRS103.dproj" auf Kno
ten "1", rebuild Ziel(e).
E:\Benutzer\KHJL\Delphi\Libs\OpenSource\SourceForge\Gexperts\Projects\DelphiXx103\GExpertsRS103.dproj : error MSB4057:
Das Ziel "rebuild" ist im Projekt nicht vorhanden.
Die Erstellung des Projekts "E:\Benutzer\KHJL\Delphi\Libs\OpenSource\SourceForge\Gexperts\Projects\DelphiXx103\GExperts
RS103.dproj" ist abgeschlossen, rebuild Ziel(e) -- FEHLER.

Fehler beim Buildvorgang.

"E:\Benutzer\KHJL\Delphi\Libs\OpenSource\SourceForge\Gexperts\Projects\DelphiXx103\GExpertsRS103.dproj" (rebuild Ziel)
(1) ->
  E:\Benutzer\KHJL\Delphi\Libs\OpenSource\SourceForge\Gexperts\Projects\DelphiXx103\GExpertsRS103.dproj : error MSB4057
: Das Ziel "rebuild" ist im Projekt nicht vorhanden.

    0 Warnung(en)
    1 Fehler

Verstrichene Zeit 00:00:00.03
done building
Drücken Sie eine beliebige Taste . . .

 

[KHJ 8]

I installed it manually and during start up of the IDE the following error message comes up about the missing icon.

 

Some of the default GExperts icons are missing.  Make sure that the icons exist in a directory called "Icons" underneath the main GExperts installation directory and is included in "GXIcons.rc".  The file missing is: TGxGotoPrevModification.bmp

[dummzeuch 1506]

13 minutes ago, KHJ said:

I have installed 10.2 Pro and 10.3 Pro

The current build process with __build.cmd is not working for me.

 

 

[KHJ 8]

Not sure, because TMS talked about the workaround for an ISO install.

I installed via GetIt and my FrameworkDir seems to be correct and the dir is also available on the disc.

 

@SET BDS=C:\Program Files (x86)\Embarcadero\Studio\20.0
@SET BDSINCLUDE=C:\Program Files (x86)\Embarcadero\Studio\20.0\include
@SET BDSCOMMONDIR=C:\Users\Public\Documents\Embarcadero\Studio\20.0
@SET FrameworkDir=C:\Windows\Microsoft.NET\Framework\v4.0.30319
@SET FrameworkVersion=v4.5
@SET FrameworkSDKDir=
@SET PATH=%FrameworkDir%;%FrameworkSDKDir%;C:\Program Files (x86)\Embarcadero\Studio\20.0\bin;C:\Program Files (x86)\Embarcadero\Studio\20.0\bin64;C:\Program Files (x86)\Embarcadero\Studio\20.0\cmake;C:\Users\Public\Documents\Embarcadero\InterBase\redist\InterBaseXE7\IDE_spoof;%PATH%