bug Delphi (Win32) quiets signaling NaN on function return

[Jim McKeeth 85]

I found myself down the rabbit hole of IEEE 754 standard on Floating-Point numbers (which Delphi follows), specifically the different values of NaN.... There are multiple potential internal values for NaN, all which evaluate as fsNaN. I found what I believe to be a bug, but I'm curious if anyone else has any thoughts on it. (As I was writing this up I discovered the behavior is only on Win32, so I've decided it must be a bug (RSS-1831), but sharing here anyway because I find the details interesting.)

 

In short: IEEE 754 distinguishes between Signaling NaN and Quiet NaN. Delphi defaults to Quiet NaN, but you can make it signaling manually. Unfortunately, when a float is returned from a function in the Win32 compiler, the quiet flag is set. I was testing to see if Delphi converted it into an exception, which would be understandable, but instead it just silently sets the quiet flag, suppressing the signaling state.

 

Testing in FPC, Delphi Win64, or Delphi Linux64, and the flag value doesn't change, which is what I would expect.

 

Detailed explanation and background

 

IEEE 754 divides a float into 3 parts

 

1. Sign
2. Exponent
3. Fraction

 

For a NaN the Exponent bits are all set ($FF in Single), any value for sign (Delphi's default NaN has it set, making it a negative NaN, which doesn't carry any specific significance), and the Fraction is anything but all 0. This allows for quiet a few different values that all are treated as NaN. What may distinguish the different values of NaN is signaling vs. quiet NaN. The Quiet flag is usually the first bit of the fraction. When the quiet flag isn't set, then it is considered a signaling NaN.

 

The internal the internal representation of a NaN is typically displayed as follows (notice this is reversed from how Delphi stores the value in memory to put the most significant bit first.)

S   Exponent   Fraction
1 | 11111111 | 10000000000000000000000
               ^ The quiet flag  

So a signaling NaN is has an value for Faction without that first bit set.

 

 

What I found in Delphi Win32 is it handles all these values correctly, except that if the quiet flag is missing (making it a signaling NaN), then when the value is returned from a function the quiet flag is set.

 

Before returning from function: (Notice that the debugger recognizes it as negative NaN. Very nice!)

 

This is 1 | 11111111 | 00000000000000000000001 in binary, which doesn't have the Quiet flag set

 

1 | 11111111 | 10000000000000000000001
After return it isn't the Default NaN, but it is the previous value with the Quiet flag set.

 

Here is some sample code that demonstrates the behavior

// The Delphi Win32 (tested in Delphi 12.1 and 12.2) sets NaN's quiet flag when are returning from a function
// More information on IEEE 754 NaN https://en.wikipedia.org/wiki/NaN#Quiet_NaN
// More information on this code: https://gist.github.com/jimmckeeth/2b4f017917afbae88ee7a3deb75b4ef7
program NaNSignalBug;

{$APPTYPE CONSOLE}

uses
  System.SysUtils;//, SingleUtils in 'SingleUtils.pas';

function is_Signaling(const NaN: Single): Boolean;
begin
  Result := NaN.IsNan and (NaN.Frac and $400000 = 0);
end;

function NaNDetails(const Value: Single): string;
begin
  if value.IsNan then
  begin
    if is_Signaling(value) then
      Result := 'NaN is Signaling'
    else
      Result := 'NaN is Quiet';
  end else
    Result := 'Not a NaN';
end;

procedure MakeSignaling(var NaN: Single);
begin
  NaN.Exp := 255;
  NaN.Frac := NaN.Frac and not (1 shl 22);
  Assert(is_Signaling(NaN));
  Writeln('Manipulated: ',NaNDetails(NaN),#9, '// Line 33');
end;

// When a NaN is returned from a function the Signal bit is set
function SignalingNaN: Single;
begin
  Result := Single.NaN;
  Result.Frac := 1;
  MakeSignaling(Result);
  Assert(is_Signaling(Result));
  Writeln(#9,'SignalingNaN Returning',#9'// Line 43');
end;

function NestedNaN: Single;
begin
  var NaN : Single := SignalingNaN;
  // The quiet bit was set
  Writeln('Returned:    ',NaNDetails(NaN),#9, '// Line 50');
  // without returning it from a function it works fine
  MakeSignaling(NaN);
  Writeln('Manipulated: ',NaNDetails(NaN),#9, '// Line 53');
  Assert(is_Signaling(NaN));
  Writeln(#9,'NestedNaN Returning ',#9,'// Line 55');
  Exit(NaN);
end;


begin
  try
    Writeln(TOSVersion.ToString);
    Writeln('Used: ',SizeOf(NativeInt)*8,'-bit compiler');
    var NaN : Single := NestedNaN;
    // The quiet bit was set
    Writeln('Returned:    ', NaNDetails(NaN),#9,'// Line 66');
    //Assert(is_Signaling(NaN)); // Fails on Win32
    // without returning it from a function it works fine
    MakeSignaling(NaN);
    Writeln('Manipulated: ', NaNDetails(NaN),#9,'// Line 70');
    Assert(is_Signaling(NaN));
  except
    on E: Exception do
      Writeln(E.ClassName, ': ', E.Message);
  end;
  readln;
end.

and here is the output

Windows 11 (Version 23H2, OS Build 22631.4169, 64-bit Edition)
Used: 32-bit compiler
Manipulated: NaN is Signaling   // Line 33
        SignalingNaN Returning  // Line 43
Returned:    NaN is Quiet       // Line 50
Manipulated: NaN is Signaling   // Line 33
Manipulated: NaN is Signaling   // Line 53
        NestedNaN Returning     // Line 55
Returned:    NaN is Quiet       // Line 66
Manipulated: NaN is Signaling   // Line 33
Manipulated: NaN is Signaling   // Line 70

and a more detailed look at the NaN values

Default NaN
Value of :                     Nan
Special  : fsNaN
Sign     : TRUE
Exponent : 255
Fraction : 4194304
Size     : 4
InvertHex: $FFC00000
1 | 11111111 | 10000000000000000000000
-----------------

Singnaling NaN
Value of :                     Nan
Special  : fsNaN
Sign     : TRUE
Exponent : 255
Fraction : 1
Size     : 4
InvertHex: $FF800001
1 | 11111111 | 00000000000000000000001
-----------------

Returned from Function
Value of :                     Nan
Special  : fsNaN
Sign     : TRUE
Exponent : 255
Fraction : 4194305
Size     : 4
InvertHex: $FFC00001
1 | 11111111 | 10000000000000000000001

@David Heffernan it was suggested I tag you on this...

NaNSignalBug.dpr

[David Heffernan 2331]

I don't have anything later than 11.3 installed. So there are likely changes that I'm not familiar with. 

 

The one thing that jumps to my mind is the ABI. Floating point return values travel via ST(0) in x86 but by a general purpose register in x64 (can't remember which). 

 

This means that it has traditionally not been possible to return SNaN by function return value in 32 bit, although it is possible to in 64 bit. That's because loading into ST(0) triggers invalid op. 

 

But now fp exceptions are masked by default. 

 

Anyway, that's all I know right now, not at a computer. 

[DelphiUdIT 152]

The result value is coming from FPU register ST(0) like @David Heffernan told.

The issue is that the code load in ST(0) the correct signaling NAN, but become quieted NAN in ST(0).

 

This is not an Issue from Embarcadero, but may be an hardware setting. I am far from FPU registers (working with them at time of  I486DX ).

 

 

EDIT: From what I read in the Intel manuals, it seems that the impersonation is internally QNAN if the FPU "invalid operation" exception is masked. (ref 4.8.3.6 of Intel manual "325462-sdm-vol-1-2abcd-3abcd-4"). There are many tables inside that show how hardware treats the NAN.

Edited 18 hours ago by DelphiUdIT

[Anders Melander 1730]

https://developercommunity.visualstudio.com/t/signaling-nan-float-double-becomes-quiet-nan-when/903305#T-N1065496

https://stackoverflow.com/questions/22816095/signalling-nan-was-corrupted-when-returning-from-x86-function-flds-fstps-of-x87

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57484

Quote

On an x86 target using the legacy x87 instructions and the 80-bit registers, a load of a 64-bit or 32-bit value in memory into the 80-bit registers counts as a format conversion and an signaling NaN input will turn into a quiet NaN in the register format.

So apparently this is just the way things are on x86.

[DelphiUdIT 152]

To summarize:

 

x86 (32-bit):

1) "Quiet NAN" can always be used;

2) UnMasked Invalid Operation :
- "Signaling NAN" throws an exception if used with FPU registers (i.e function return value);

3) Masked Invalid Operation:
- "Signaling NAN" is switched to "Quiet NAN" if used with FPU registers (i.e function return value);

N.B.: if you pass the "Signaling NAN" via function parameter then you can use it 'cause no FPU register is involving.

 

 

x64 (64-bit):

1) "Quiet NAN" can always be used;

2) "Signaling NAN" can always be used;

Edited 7 hours ago by DelphiUdIT

[Jim McKeeth 85]

Great, thanks everyone!