The 9 Hints in MARS

[Yaron 53]

Due to Delphi's inability to register changes in included ({$I filename}) files when performing a standard compile, I am forced to do a full build which brings up warning/hints from underlying units.

 

With MARS, I always see these 9 Hints:

[dcc32 Hint] MARS.Core.JSON.pas(264): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Core.JSON.pas(384): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Core.JSON.pas(473): H2443 Inline function 'TJSONObject.GetPair' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Core.JSON.pas(822): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Core.MessageBodyWriters.pas(129): H2443 Inline function 'TJSONArray.AddElement' has not been expanded because unit 'System.JSON' is not specified in USES list
[dcc32 Hint] MARS.Core.MessageBodyWriters.pas(275): H2443 Inline function 'TJSONArray.AddElement' has not been expanded because unit 'System.JSON' is not specified in USES list
[dcc32 Hint] MARS.Core.MessageBodyReaders.pas(302): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Core.MessageBodyReaders.pas(366): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Data.Utils.pas(213): H2443 Inline function 'TJSONArray.AddElement' has not been expanded because unit 'System.JSON' is not specified in USES list

Any merit to these hints?

[Markus Kinzler 174]

Include the unit.

[Yaron 53]

3 minutes ago, Markus Kinzler said:

Include the unit.

I did, but it will get overwritten the next time I pull the code to get the latest version...

Edited August 20, 2019 by Yaron

[Stefan Glienke 2002]

Then submit a pull request with the necessary changes to get rid of the hints.

 

P.S. Btw proper use of git will not overwrite your local changes fwiw

Edited August 20, 2019 by Stefan Glienke

[Andrea Magni 75]

@Yaron are you using the master or develop branch?

 

I can't see hints/warnings using the develop branch.

 

Sincerely,

Andrea

[Yaron 53]

After doing a clean install of Delphi 10.3.3, I had to re-install mars, so I did a zip download directly from GitHub and on a re-compile, it still shows 3 hints:

[dcc32 Hint] MARS.Core.MessageBodyReaders.pas(302): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Core.MessageBodyReaders.pas(366): H2443 Inline function 'TJSONArray.GetValue' has not been expanded because unit 'System.Generics.Collections' is not specified in USES list
[dcc32 Hint] MARS.Data.Utils.pas(213): H2443 Inline function 'TJSONArray.AddElement' has not been expanded because unit 'System.JSON' is not specified in USES list

I of course fixed it myself in a few seconds, just an FYI.

Edited November 24, 2019 by Yaron