Jump to content
PeterPanettone

Bugs in GExperts source code?

Recommended Posts

Today I downloaded gexperts-code-r3054-trunk , extracted it to C:\COMP\_Addons\GExperts\GExperts Sourcecode\gexperts-code-r3054-trunk and tried to build it by loading:

C:\COMP\_Addons\GExperts\GExperts Sourcecode\gexperts-code-r3054-trunk\Projects\DelphiXx103\GExpertsRS103.dproj into the Delphi 10.3.3 IDE.

 

First, it complained about a file not found OUTSIDE (!) its own directory:

 

[Exec Error] EXEC(1): File "C:\COMP\_Addons\GExperts\GExperts_Version.ini" does not exist. (ENoVersionInfo)

 

So I copied it from C:\COMP\_Addons\GExperts\GExperts Sourcecode\gexperts-code-r3054-trunk\Projects\GExperts_version.ini to the required location.

 

Then it complained about another missing file:

 

[dcc32 Error] E1026 File not found: 'GExpertsRS103_version.res'

 

So I RENAMED (!) C:\COMP\_Addons\GExperts\GExperts Sourcecode\gexperts-code-r3054-trunk\Projects\DelphiXx103\GExpertsRS103.res to GExpertsRS103_version.res.

 

Only after these two actions,  the GExpertsRS103.dll could be successfully built and is now happily living in the 10.3.3 IDE:

 

image.thumb.png.a7402567239c23e593f4f829d390babd.png

 

Are these bugs inside the GExperts source code?

Share this post


Link to post

Hm, looks like somewhere a relative path is resolved wrongly.

 

 GExpertsRS103.res is not the same file as

GExpertsRS103_version.res. The former is automatically created by the IDE and should not be referenced in the project. The latter is supposed to be generated by the pre-build script, which reads the  version number from the GExperts_version.ini file, creates an .rc file from it and then compiles it to the .res file. Apparently that process is broken.

Share this post


Link to post

I just tried to reproduce this problem:

* Deleted all files in the Projects\DelphiXx103 that are not under source control (including the GExpertsRS103_Version.RES file you mention

* Deleted all files in the dcu subdirectory

* run the _Build_Project.cmd file

 

I got no error messages.

Share this post


Link to post

OK, I know what the problem is: The GExperts build scripts do not support paths that include a space character.

(Which is actually documented.)

Rename your "GExperts Sourcecode" directory so it does not contain a space character and it should work.

Share this post


Link to post
Posted (edited)
7 hours ago, dummzeuch said:

The GExperts build scripts do not support paths that include a space character.

Thomas, thanks for your efforts!

 

Please fix that STONE-AGE BUG of not supporting paths that include a space character. CommandLine scripts solve this problem by double-quoting paths.

Edited by PeterPanettone

Share this post


Link to post

No, I won't. It's just an annoyance and can be worked around easily.

But if you think it is worth your time: Go ahead.

Share this post


Link to post
Posted (edited)
31 minutes ago, dummzeuch said:

It's just an annoyance

I wouldn't call that just an annoyance. It's a BUG.

Edited by PeterPanettone

Share this post


Link to post
9 hours ago, PeterPanettone said:

Please fix that STONE-AGE BUG of not supporting paths that include a space character.

Why don't you have a go at fixing it, and contributing the fix? 

Share this post


Link to post
Posted (edited)
20 minutes ago, David Heffernan said:

Why don't you have a go at fixing it, and contributing the fix?

Is that a MORAL or RELIGIOUS assessment?

Edited by PeterPanettone

Share this post


Link to post
23 minutes ago, PeterPanettone said:

Is that a MORAL or RELIGIOUS assessment?

No. It's a suggestion that if you want an improvement to an open source project then one option is that you contribute it yourself. 

 

ALL-CAPSing the project maintainer is a strategy that in my opinion is sub optimal for your goals. 

  • Like 2

Share this post


Link to post
1 hour ago, David Heffernan said:

It's a suggestion

Thank you for the suggestion.

 

1 hour ago, David Heffernan said:

ALL-CAPSing

You mean "ALL-CAPSing"?

Share this post


Link to post
3 hours ago, PeterPanettone said:

I wouldn't call that just an annoyance. It's a BUG.

IT'S A PROBLEM IN THE BUILD PROCESS THAT ONLY AFFECTS THOSE WHO USE IT.

 

I DON'T CARE IF YOU CALL IT A BUG, FOR ME IT'S AN ANNOYANCE AND THERE IS A SIMPLE WORKAROUND THAT TAKES ALL OF 30 SECONDS TO APPLY. FIXING THIS SO CALLED BUG WOULD TAKE ME AT LEAST HALF AN HOUR. AND THAT'S MY TIME, NOT YOURS.

 

(OK, I will stop using caps now.)

 

I won't take the time to fix this, it doesn't affect me. If you want it fixed, fix it yourself.

  • Haha 1

Share this post


Link to post
Posted (edited)
1 hour ago, dummzeuch said:

OK, I will stop using caps now.

You're alright with David making you upset? Don't let your feelings get manipulated. Think rationally. The weather is beautiful today.

Edited by PeterPanettone

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×