Performance of MOVE vs + for concatenating mixed type values

[Mike Torrettinni 198]

With new 'knowledge', I tested what happens if I add values in consecutive expressions, like this:

 

function PrepareLineForExport2(const aDataIn: TData): string;
begin
  Result := aDataIn.ID1.ToString            + cSeparator;
  Result := Result +  aDataIn.S1            + cSeparator;
  Result := Result +  BoolToStr(aDataIn.B1) + cSeparator;
  Result := Result +  aDataIn.S2            + cSeparator;
  Result := Result +  aDataIn.C1            + cSeparator;
  Result := Result +  aDataIn.S3;
end;

OK, this is now slower:

PrepareLineForExport: 1358 ms (single expression using + )

PrepareLineForExport2: 2242 ms

 

I realize this is probably the most basic thing for most of you, for me this is something really new.

 

[Attila Kovacs 629]

3 minutes ago, Mike Torrettinni said:

With new 'knowledge'

You mean after somebody read the RTL code for you?

[Rollo62 536]

15 minutes ago, Mike Torrettinni said:

With new 'knowledge', I tested what happens if I add values in consecutive expressions, like this:

 

function PrepareLineForExport2(const aDataIn: TData): string;
begin
  Result := aDataIn.ID1.ToString            + cSeparator;
  Result := Result +  aDataIn.S1            + cSeparator;
  Result := Result +  BoolToStr(aDataIn.B1) + cSeparator;
  Result := Result +  aDataIn.S2            + cSeparator;
  Result := Result +  aDataIn.C1            + cSeparator;
  Result := Result +  aDataIn.S3;
end;

OK, this is now slower:

PrepareLineForExport: 1358 ms (single expression using + )

PrepareLineForExport2: 2242 ms

 

I realize this is probably the most basic thing for most of you, for me this is something really new.

 

function PrepareLineForExport2(const aDataIn: TData): string;
begin
  Result :=    aDataIn.ID1.ToString            
             +     cSeparator 
             + aDataIn.S1            
             +     cSeparator
             + BoolToStr(aDataIn.B1)
             +     cSeparator
             + aDataIn.S2
             +     cSeparator
             +  aDataIn.C1
             +     cSeparator
             +  aDataIn.S3
             ;
end;

Sometimes I like to use a "prefix" pattern like this.

To make things visually more readble, and to easily include/exclude parts for testing ( by puttin // in frontt).

[Lars Fosdal 1792]

Moved the questions meta discussion to a separate thread.