ISAPI in Delphi 10.2,10.3 TranslateURI

[hsvandrew 23]

This note is for anyone going about creating an ISAPI in modern versions of Delphi. Request.TranslateURI has been broken (and still remains unfixed in 10.3)for a number of releases.

TranslateURI is useful if you run multiple sites on the same IIS server and want to work out the base folder of the site i.e. request.TranslateURI('/')  to work out which customer experience/domain etc you are currently serving.

 

I'm not sure if this code covers every unicode etc scenario, but for basic needs it works whereas the built in code does not.

You'll need to modify C:\Program Files (x86)\Embarcadero\Studio\20.0\source\internet\Web.Win.IsapiHTTP.pas 

You need to then ADD the Web.Win.IsapiHTTP.pas  to your project with the full source path

 

I'm surprised this bug hasn't had more attention and have to wonder how much web work is going on in Delphi.

 

**please see below for updated version from another member**

function TISAPIRequest.TranslateURI(const URI: string): string;
var
PathBuffer: array[0..1023] of AnsiChar;
Size: Integer;
begin
System.AnsiStrings.StrCopy(PathBuffer, PAnsiChar(AnsiString(URI)));
Size := SizeOf(PathBuffer);
if ECB.ServerSupportFunction(ECB.ConnID, HSE_REQ_MAP_URL_TO_PATH,
@PathBuffer, @Size, nil) then
Result := string(PathBuffer)
else Result := '';
end;

 

[Attila Kovacs 629]

Do you have a QP #? What is the problem exactly?

[hsvandrew 23]

Returns a blank string, yes logged 

https://quality.embarcadero.com/browse/RSP-17838

[Attila Kovacs 629]

You should wipe your version from the net then it's vulnerable as you are not checking the length of the URI.

 

Looks like somebody went to get a coffee at emba in the middle of the refactoring.

 

The right code should be:

 

function TISAPIRequest.TranslateURI(const URI: string): string;
var
  Size: integer;
  LBytes: TBytes;
begin
  LBytes := DefaultCharSetEncoding.GetBytes(URI);
  Size := Length(LBytes);
  SetLength(LBytes, 1024);
  LBytes[Min(Size, Length(LBytes) - 1)] := 0; // null terminator
  Size := Length(LBytes);
  if ECB.ServerSupportFunction(ECB.ConnID, HSE_REQ_MAP_URL_TO_PATH, LBytes, @Size, nil) then
    Result := DefaultCharSetEncoding.GetString(LBytes, 0, Size - 1); // Dmitry Arefiev Instead of last "Size" reference there should be "Size - 1"
end;

Can be easily put into an interposer hack/fake-class.

 

Edited January 14, 2019 by Attila Kovacs

[Dmitry Arefiev 101]

Instead of last "Size" reference there should be "Size - 1". Fixed.

[Attila Kovacs 629]

@Dmitry Arefiev Thank you, this was fast, I've also edited to have the correct code here.

[Andrea Magni 75]

23 hours ago, hsvandrew said:

This note is for anyone going about creating an ISAPI in modern versions of Delphi. Request.TranslateURI has been broken (and still remains unfixed in 10.3)for a number of releases.

TranslateURI is useful if you run multiple sites on the same IIS server and want to work out the base folder of the site i.e. request.TranslateURI('/')  to work out which customer experience/domain etc you are currently serving.

 

There's no entry for my MARS REST library (https://github.com/andrea-magni/MARS) in your poll...

I am happily doing web backend development since years, using DataSnap at first. Using MARS since it exists 😉

 

[Markus Kinzler 174]

Unfortunately I can't add this option. And if he adds it, all existant votes are lost.

[hsvandrew 23]

On 1/15/2019 at 5:52 PM, Andrea Magni said:

 

There's no entry for my MARS REST library (https://github.com/andrea-magni/MARS) in your poll...

I am happily doing web backend development since years, using DataSnap at first. Using MARS since it exists 😉

 

Apologies @Andrea Magni I wasn't able to edit the survey once it collected results and I wasn't aware of the MARS REST Library

[Andrea Magni 75]

14 hours ago, hsvandrew said:

Apologies @Andrea Magni I wasn't able to edit the survey once it collected results and I wasn't aware of the MARS REST Library

No worries 🙂

If you need some information about the library, feel free to ask me (there is a dedicated subforum in the third party group).

 

Sincerely,

Andrea

[Guest]

Isapi or apache?

Edited January 22, 2019 by Guest

[Alex7691 7]

This is an old thread that was pointed out to me by an IntraWeb user. I'm adding some information for future readers.

 

IntraWeb has it's own ISAPI classes and doesn't rely at all on Delphi's IsapiHTTP.pas (or any other Delphi Web.* namespace unit). Any bug in that area doesn't affect IntraWeb applications.

 

Cheers,