Delphi 12.2 TMEMO - indexoutofbounds

[Borni 0]

HI Folks,

with the return key in a tmemo it crahses with the message

java.lang.indexoutofboundsexception

 under Android32/64.

Someone must have noticed this before !!!

 

BR Borni

[hsauro 37]

What framework, VCL or FMX?

Edited yesterday at 03:29 PM by hsauro

[Uwe Raabe 2000]

28 minutes ago, hsauro said:

What framework, VCL or FMX?

Really?

47 minutes ago, Borni said:

under Android32/64.

 

[JonRobertson 64]

2 hours ago, Uwe Raabe said:

2 hours ago, Borni said:

under Android32/64.

 

And in the topic

 

[alejandro.sawers 9]

3 hours ago, Borni said:

with the return key in a tmemo it crahses with the message

java.lang.indexoutofboundsexception

 under Android32/64.

A quick test on a Delphi 12.2 blank FMX app with only a TMemo, compiled for Android 64, running on an Android 13 device doesn't show such error.

Maybe test with a blank project to discard issues with your Delphi/Android SDK installation.

[hsauro 37]

10 hours ago, Uwe Raabe said:

Really?

 

Oops sorry. Teach me a lesson for posting.

[Borni 0]

11 hours ago, alejandro.sawers said:

A quick test on a Delphi 12.2 blank FMX app with only a TMemo, compiled for Android 64, running on an Android 13 device doesn't show such error.

Maybe test with a blank project to discard issues with your Delphi/Android SDK installation.

Nokia 5.4 with Android 12 - > ok

Google Pixel 8 Android 14 -> ok

Samsung S23 Android 14 -> Exception

Galaxy s10+ Android 12 -> Exception

Galaxy s24+ Android 14 -> Exception

Galaxy Tab A Android 7.1.1 -> Exception

 

all samsung devices !

Edited 15 hours ago by Borni

[havrlisan 8]

Exception occurs on my A52s as well. To reproduce, write a character and press the Return key. Pressing the Return key on an empty line doesn't trigger the exception.

[Chris Pim 34]

Looks very serious. Can you please log it with Embarcadero in their quality portal so they can start investigating? We might get a quick patch from them with any luck.
https://embt.atlassian.net/servicedesk/customer/portals

Edited 13 hours ago by Chris Pim

[havrlisan 8]

Upon closer inspection, it has nothing to do with the Return key, but with the caret position. The bug can be reproduced just by tapping on another line, the only condition is that the current line must have at least one character.
 

Stack trace:

System._DbgExcNotify(int, void*, System.SmallString<(unsigned char)255>*, void*, void*)
System.NotifyReRaise(System.TObject*, void*)($b40000deac336980,$0000006ef3035c10)
System._InternalRaiseAtExcept(System.TObject*, void*, bool)($b40000deac336980,$0000006ef3035c10,false)
System._RaiseExcept(System.TObject*)($b40000deac336980)
System.Internal.Excutils.DoRaiseJNIExceptionCallBack(System.UnicodeString, System.UnicodeString)(??,??)
Androidapi.Jni.HandleJNIException(JNINativeInterface**)($b40000701924bbf0)
Androidapi.Jnimarshal.ExecJNI(void*, void*, void*, Androidapi.Jnimarshal.JNIMethodInvokeData*, Androidapi.Jnimarshal.m128*)($0000007fe4a32218,$0000007fe4a321f8,$0000007fe4a322f0,$0000007fe4a32200,$0000007fe4a32210)
_DispatchToImport
Fmx.Platform.Ui.Android.TTextServiceAndroid.InternalUpdateSelection()($b4000070c92faf10)
Fmx.Platform.Ui.Android.TTextServiceAndroid.SetText(System.UnicodeString)($b4000070c92faf10,??)
Fmx.Text.Texteditor.TTextEditor.UpdateTextInTextService()($b4000070192bc510)
Fmx.Text.Texteditor.TTextEditor.SetCaretPosition(Fmx.Text.TCaretPosition const&)($b4000070192bc510,{Line = 1, Pos = 0})
Fmx.Memo.Style.New.TStyledMemo.MMSetCaretPosition(Fmx.Presentation.Messages.TDispatchMessageWithValue__1<Fmx.Text.TCaretPosition>&)($b4000070e92689d0,{MsgID = 5917, Value = {Line = 1, Pos = 0}})
System.TObject.Dispatch(void*)($b40000dfdc2671e0,$0000007fe4a326d8)
void Fmx.Presentation.Messages.TMessageSender.SendMessage<Fmx.Text.TCaretPosition>(unsigned short, Fmx.Text.TCaretPosition)($b4000070192bf450,5917,{Line = 1, Pos = 0})
Fmx.Memo.TCustomMemoModel.SetCaretPosition(Fmx.Text.TCaretPosition const&)($b4000070192bf450,{Line = 1, Pos = 0})
Fmx.Memo.TCustomMemoModel.InsertAfter(Fmx.Text.TCaretPosition const&, System.UnicodeString, System.Set<Fmx.Text.TInsertOption, (Fmx.Text.TInsertOption)0, (Fmx.Text.TInsertOption)4>)(??,{Line = 0, Pos = 1},??,{__data = "\\U00000006", __basetype = ??})
Fmx.Memo.Style.New.TStyledMemo.KeyDown(unsigned short&, char16_t&, System.Set<System.Classes.TShiftStateItem, (System.Classes.TShiftStateItem)0, (System.Classes.TShiftStateItem)10>)(??,$0000007fe4a32fa2,U+2fa4 U+e4a3 U+007f U+0000 u'\\xe2\\xbe\\xa4',{__data = "", __basetype = ??})
Fmx.Presentation.Style.TStyledPresentation.PMKeyDown(Fmx.Presentation.Messages.TDispatchMessageWithValue__1<Fmx.Controls.Presentation.TKeyInfo>&)($b4000070e92689d0,{MsgID = 1056, Value = {Key = 13, KeyChar = U+0000 u'\\\\0', Shift = {__data = "", __basetype = ??}}})
System.TObject.Dispatch(void*)($b40000dfdc2671e0,$0000007fe4a32fa0)
void Fmx.Presentation.Messages.TMessageSender.SendMessageWithResult<Fmx.Controls.Presentation.TKeyInfo>(unsigned short, Fmx.Controls.Presentation.TKeyInfo&)($b400006fb92f9d80,1056,{Key = 13, KeyChar = U+0000 u'\\\\0', Shift = {__data = "", __basetype = ??}})
Fmx.Controls.Presentation.TPresentedControl.KeyDown(unsigned short&, char16_t&, System.Set<System.Classes.TShiftStateItem, (System.Classes.TShiftStateItem)0, (System.Classes.TShiftStateItem)10>)($b400006f99280520,$0000007fe4a3330a,U+3302 U+e4a3 U+007f U+0000 u'\\xe3\\x8c\\x82',{__data = "", __basetype = ??})
Fmx.Forms.TCommonCustomForm.KeyDown(unsigned short&, char16_t&, System.Set<System.Classes.TShiftStateItem, (System.Classes.TShiftStateItem)0, (System.Classes.TShiftStateItem)10>)($b400006f9927be50,$0000007fe4a3330a,U+3302 U+e4a3 U+007f U+0000 u'\\xe3\\x8c\\x82',{__data = "", __basetype = ??})
Fmx.Platform.Ui.Android.TAndroidTextInputManager.KeyDown(unsigned short&, char16_t&, System.Set<System.Classes.TShiftStateItem, (System.Classes.TShiftStateItem)0, (System.Classes.TShiftStateItem)10>)($b400007009347710,$0000007fe4a3330a,U+3302 U+e4a3 U+007f U+0000 u'\\xe3\\x8c\\x82',{__data = "", __basetype = ??})
Fmx.Platform.Ui.Android.TAndroidTextInputManager.HandleAndroidKeyEvent(AInputEvent*)($b400007009347710,$b40000700939d2a0)
Fmx.Platform.Android.TPlatformAndroid.HandleAndroidInputEvent(Androidapi.Appglue.TAndroidApplicationGlue*, AInputEvent*)($b4000070192be490,$b40000700939d2a0)
Androidapi.Appglue.TAndroidApplicationGlue.InputEventHandler(int, int, void*)
:0000007234A78B74 android::Looper::pollInner(int)
:0000007234A7862C android::Looper::pollOnce(int, int*, int*, void**)
:00000072278C689C ___lldb_unnamed_symbol9344
:000000009D7B6340 ??

 

The TTextEditor.FCaretPosition was updated while TTextService.FCaretPosition wasn't, and the TTextEditor.UpdateTextInTextService gets called before the TTextService receives the position update. The UpdateTextInTextService passes the string of the newly selected line to the TTextService.SetText, which, among other code, does this:

FTextView.setText(StrToJCharSequence(FText), TJTextView_BufferType.JavaClass.EDITABLE);
// In some cases, EditText can reset selection/caret position to 0. So if user removes text via vkBackspace,
// the backspace button in Soft Keyboard can be unpressed automatically.
InternalUpdateSelection;

Judging from the comment, that second line seems like a new addition. Tracing into it, lo and behold:

procedure TTextServiceAndroid.InternalUpdateSelection;
var
  SelStart, SelEnd: Integer;
begin
  if FTextView = nil then
    Exit;

  CalculateSelectionBounds(SelStart, SelEnd);
  if SelEnd - SelStart > 0 then
    FTextView.setSelection(SelStart, SelEnd)
  else
    FTextView.setSelection(CaretPosition.X); // this one gets executed
end;

It uses its non-updated caret position to update the selection.

Edited 13 hours ago by havrlisan
typo

[havrlisan 8]

Reported on QP: https://embt.atlassian.net/servicedesk/customer/portal/1/RSS-1840

[Borni 0]

43 minutes ago, havrlisan said:

Reported on QP: https://embt.atlassian.net/servicedesk/customer/portal/1/RSS-1840

in FMX.Platform.UI.Android.pas

markieren

Code:

procedure TTextServiceAndroid.InternalUpdateSelection;
var
  SelStart, SelEnd: Integer;
begin
  if FTextView = nil then
    Exit;

  CalculateSelectionBounds(SelStart, SelEnd);
  if SelEnd - SelStart > 0 then
    FTextView.setSelection(SelStart, SelEnd)
  else
    FTextView.setSelection(JCharSequenceToStr(FTextView.getText).length); // the chagnes found by Enri
end;

[alejandro.sawers 9]

Put my hands on a Samsung A12 and can confirm the issue when pressing the return key:

 

 

Testing on a Redmi Note 11 doesn't cause the exception, but by @havrlisan's comment it does happen when tapping on the memo to move the caret from a non-empty line to an empty one.

3 hours ago, Borni said:

in FMX.Platform.UI.Android.pas

markieren

Code:

procedure TTextServiceAndroid.InternalUpdateSelection;
var
  SelStart, SelEnd: Integer;
begin
  if FTextView = nil then
    Exit;

  CalculateSelectionBounds(SelStart, SelEnd);
  if SelEnd - SelStart > 0 then
    FTextView.setSelection(SelStart, SelEnd)
  else
    FTextView.setSelection(JCharSequenceToStr(FTextView.getText).length); // the chagnes found by Enri
end;

This change seems to solve the issue on both Samsung and non-Samsung devices.

[Ian Barker 19]

Thanks for letting us know about this. I have raised it with the PM team to look at and validate ASAP. FWIW my own personal mobile is a Samsung device.